Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature request tpl #6

Closed
wants to merge 11 commits into from
Closed

Add feature request tpl #6

wants to merge 11 commits into from

Commits on Oct 9, 2024

  1. feat(bazel): support building C++ libs on windows platform (apache#1873)

    <!--
    **Thanks for contributing to Fury.**
    
    **If this is your first time opening a PR on fury, you can refer to
    [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).**
    
    Contribution Checklist
    
    - The **Apache Fury (incubating)** community has restrictions on the
    naming of pr titles. You can also find instructions in
    [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).
    
    - Fury has a strong focus on performance. If the PR you submit will have
    an impact on performance, please benchmark it first and provide the
    benchmark result here.
    -->
    
    ## What does this PR do?
    
    Make bazel happy on `Windows OS`.
    
    1. Rewrite a little codes in `row.cc`, then it could be compiled by MSVC
    ([VLA is not
    supported](https://devblogs.microsoft.com/cppblog/c11-and-c17-standard-support-arriving-in-msvc/))
    2. Add MSVC flag
    [`/Zc:preprocessor`](https://learn.microsoft.com/en-us/cpp/build/reference/zc-preprocessor?view=msvc-170)
    to enable C99/C11
    3. Add MSVC flag
    [`/utf-8`](https://learn.microsoft.com/en-us/cpp/build/reference/utf-8-set-source-and-executable-character-sets-to-utf-8?view=msvc-170)
    to set source and execution character sets to UTF-8.
    4. Load arrow(arrow_python) interface libraries `*.lib` to the linker
    5. Add a new CI env `windows-2022` to build fury cpp libraries
    
    <!-- Describe the purpose of this PR. -->
    
    ## Related issues
    
    apache#798 
    
    <!--
    Is there any related issue? Please attach here.
    
    - #xxxx0
    - #xxxx1
    - #xxxx2
    -->
    
    ## Does this PR introduce any user-facing change?
    
    <!--
    If any user-facing interface changes, please [open an
    issue](https://github.com/apache/fury/issues/new/choose) describing the
    need to do so and update the document if necessary.
    -->
    
    - [ ] Does this PR introduce any public API change?
    - [ ] Does this PR introduce any binary protocol compatibility change?
    
    ## Benchmark
    
    <!--
    When the PR has an impact on performance (if you don't know whether the
    PR will have an impact on performance, you can submit the PR first, and
    if it will have impact on performance, the code reviewer will explain
    it), be sure to attach a benchmark data here.
    -->
    
    ---------
    
    Signed-off-by: Junduo Dong <[email protected]>
    An-DJ authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0e20458 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. fix(java): fix async compilation switch for non-public nested class (a…

    …pache#1883)
    
    ## What does this PR do?
    
    - fix async compilation switch for non-public nested class
    - fix install sbt for scala
    - fix install python
    
    ## Related issues
    
    Closes apache#1879 
    
    ## Does this PR introduce any user-facing change?
    
    <!--
    If any user-facing interface changes, please [open an
    issue](https://github.com/apache/fury/issues/new/choose) describing the
    need to do so and update the document if necessary.
    -->
    
    - [ ] Does this PR introduce any public API change?
    - [ ] Does this PR introduce any binary protocol compatibility change?
    
    ## Benchmark
    
    <!--
    When the PR has an impact on performance (if you don't know whether the
    PR will have an impact on performance, you can submit the PR first, and
    if it will have impact on performance, the code reviewer will explain
    it), be sure to attach a benchmark data here.
    -->
    chaokunyang authored Oct 13, 2024
    Configuration menu
    Copy the full SHA
    c8698b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. feat(kotlin): Introduce kotlin package with stdlib collections and te…

    …sts (apache#1877)
    
    
    
    ## What does this PR do?
    
    This PR adds a base project for Kotlin on the JVM.
    - It adds a pom.xml based on the java project.
    - Adds a Serializer class that registers base collection classes not
    covered by the JVM.
    - Adds code to test all documented collections in the kotlin stdlib via
    TestNG.
    - Adds register and adds serializers for EmptyList, EmptySet, EmptyMap
    classes.
    - This PR does not handle kotlin `withDefault` wrapper classes, as that
    requires serializing arbitrary lambdas.
    
    ## Related issues
    
    - apache#683
    
    ## Does this PR introduce any user-facing change?
    
    This PR creates a new fury-kotlin JAR, no documentation yet from the
    main project.
    
    - [ ] Does this PR introduce any public API change?
    - [ ] Does this PR introduce any binary protocol compatibility change?
    
    ## Benchmark
    N/A
    
    ---------
    
    Co-authored-by: Shawn Yang <[email protected]>
    wywen and chaokunyang authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0673c7b View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. feat(kotlin): Add Unsigned Primitive Support (apache#1886)

    <!--
    **Thanks for contributing to Fury.**
    
    **If this is your first time opening a PR on fury, you can refer to
    [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).**
    
    Contribution Checklist
    
    - The **Apache Fury (incubating)** community has restrictions on the
    naming of pr titles. You can also find instructions in
    [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).
    
    - Fury has a strong focus on performance. If the PR you submit will have
    an impact on performance, please benchmark it first and provide the
    benchmark result here.
    -->
    
    ## What does this PR do?
    
    This PR adds unsigned primitive support to Kotlin Fury.
    It also adds tests for the standard kotlin primitives(supported by fury
    Java), nullable primitive tests, boundary tests for unsigned
    serializers.
    
    ## Related issues
    apache#683
    
    ## Does this PR introduce any user-facing change?
    
    Yes it adds Unsigned support for Kotlin. There's documentation new issue
    (should add something to document Kotlin!)
    
    - [ ] Does this PR introduce any public API change?
    - [ ] Does this PR introduce any binary protocol compatibility change?
    
    ## Benchmark
    N/A
    
    ---------
    
    Co-authored-by: Shawn Yang <[email protected]>
    wywen and chaokunyang authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d44e27d View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. chore(py314): Replace deprecated pkgutil.find_loader (apache#1888)

    This PR removes [pkgutil.find_loader()][] and replaces it with
    [importlib.util.find_spec()][]. `find_loader` was deprecated in Python
    3.12 and will be removed in 3.14. `find_spec` has been present since
    Python 3.4.
    
    Both functions return `None` if the module loader cannot be found. For
    its use in this project, this is sufficient and no translation of the
    return value is needed.
    
    [pkgutil.find_loader()]:
    https://docs.python.org/3/library/pkgutil.html#pkgutil.get_loader
    [importlib.util.find_spec()]:
    https://docs.python.org/3/library/importlib.html#importlib.util.find_spec
    effigies authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c578cb2 View commit details
    Browse the repository at this point in the history
  2. fix(java): fix add fury thread safety issue (apache#1889)

    ## What does this PR do?
    fix add fury thread safety issue
    <!-- Describe the purpose of this PR. -->
    
    ## Related issues
    apache#1840 
    
    ## Does this PR introduce any user-facing change?
    
    <!--
    If any user-facing interface changes, please [open an
    issue](https://github.com/apache/fury/issues/new/choose) describing the
    need to do so and update the document if necessary.
    -->
    
    - [ ] Does this PR introduce any public API change?
    - [ ] Does this PR introduce any binary protocol compatibility change?
    
    ## Benchmark
    
    <!--
    When the PR has an impact on performance (if you don't know whether the
    PR will have an impact on performance, you can submit the PR first, and
    if it will have impact on performance, the code reviewer will explain
    it), be sure to attach a benchmark data here.
    -->
    chaokunyang authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    027ddaa View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. feat(kotlin): Add unsigned array support and tests for arrays and str…

    …ings (apache#1891)
    
    <!--
    **Thanks for contributing to Fury.**
    
    **If this is your first time opening a PR on fury, you can refer to
    [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).**
    
    Contribution Checklist
    
    - The **Apache Fury (incubating)** community has restrictions on the
    naming of pr titles. You can also find instructions in
    [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).
    
    - Fury has a strong focus on performance. If the PR you submit will have
    an impact on performance, please benchmark it first and provide the
    benchmark result here.
    -->
    
    ## What does this PR do?
    
    This PR adds tests for serializing/deserializing:
    - Strings (same as Java)
    - Primitive arrays in Kotlin (same as Java)
    - Array<T> in kotlin (same as Java)
    - Unsigned arrays in kotlin - `UByteArray`, `UIntArray`, `UShortArray`,
    `ULongArray`
    
    Unsigned arrays in kotlin are currently marked experimental, and are
    subject to API changes (hence the annotations needed to suppress those
    warnings).
    
    These types are implemented as a view over the signed arrays e.g.
    UByteArray is a view over ByteArray with contents reinterpreted as
    UByte, so serializers. The current implementation delegate to existing
    serializers for corresponding signed types.
    
    The xlang type id is set to LIST for unsigned types.
    
    ## Related issues
    
    apache#683
    
    <!--
    Is there any related issue? Please attach here.
    
    - #xxxx0
    - #xxxx1
    - #xxxx2
    -->
    
    ## Does this PR introduce any user-facing change?
    
    Yes. Unsigned primitives no longer need to be registered for
    `fury-kotlin`.
    
    - [ ] Does this PR introduce any public API change?
    - [ ] Does this PR introduce any binary protocol compatibility change?
    
    ## Benchmark
    N/A
    wywen authored Oct 19, 2024
    Configuration menu
    Copy the full SHA
    750a511 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. feat(java): Refactor String serialization and deserialization (apache…

    …#1890)
    
    ## What does this PR do?
    
    <!-- Describe the purpose of this PR. -->
    
    ## Related issues
    
    Closes apache#1868
    Closes apache#1754
    
    ## Does this PR introduce any user-facing change?
    
    <!--
    If any user-facing interface changes, please [open an
    issue](https://github.com/apache/fury/issues/new/choose) describing the
    need to do so and update the document if necessary.
    -->
    
    - [ ] Does this PR introduce any public API change?
    - [ ] Does this PR introduce any binary protocol compatibility change?
    
    ## Benchmark
    
    <!--
    When the PR has an impact on performance (if you don't know whether the
    PR will have an impact on performance, you can submit the PR first, and
    if it will have impact on performance, the code reviewer will explain
    it), be sure to attach a benchmark data here.
    -->
    
    ---------
    
    Co-authored-by: chaokunyang <[email protected]>
    HuangXingBo and chaokunyang authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    09abde8 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. feat(java): support thread safe register callback for scala kotlin (a…

    …pache#1895)
    
    ## What does this PR do?
     support thread safe register callback for scala kotlin
    <!-- Describe the purpose of this PR. -->
    
    ## Related issues
    
    Closes apache#1894 
    
    ## Does this PR introduce any user-facing change?
    
    <!--
    If any user-facing interface changes, please [open an
    issue](https://github.com/apache/fury/issues/new/choose) describing the
    need to do so and update the document if necessary.
    -->
    
    - [ ] Does this PR introduce any public API change?
    - [ ] Does this PR introduce any binary protocol compatibility change?
    
    ## Benchmark
    
    <!--
    When the PR has an impact on performance (if you don't know whether the
    PR will have an impact on performance, you can submit the PR first, and
    if it will have impact on performance, the code reviewer will explain
    it), be sure to attach a benchmark data here.
    -->
    chaokunyang authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    14bad42 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b12bf69 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    192a806 View commit details
    Browse the repository at this point in the history