Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add workflow for chao-os. #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sheny1xuan
Copy link

Signed-off-by: Stonexx [email protected]

Describe what this PR does / why we need it

  • Add workflow to run tests in github workflow.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@MandssS MandssS self-requested a review October 18, 2022 06:05
@@ -295,7 +295,7 @@ func burnMemWithCache(ctx context.Context, memPercent, memReserve, memRate int,
func (ce *memExecutor) start(ctx context.Context, memPercent, memReserve, memRate int, burnMemMode string, includeBufferCache bool, avoidBeingKilled bool, cl spec.Channel) {
// adjust process oom_score_adj to avoid being killed
if avoidBeingKilled {
scoreAdjFile := fmt.Sprintf(processOOMAdj, os.Getpid())
scoreAdjFile := fmt.Sprintf(processOOMAdj, strconv.Itoa(os.Getpid()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

processOOMAdj = "/proc/%d/oom_adj", so need not strconv

@MandssS
Copy link
Contributor

MandssS commented Oct 20, 2022

- name: Checkout
id: checkout
uses: actions/checkout@v2
- name: Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以增加一些前置:
go get -v -t -d ./...
diff -u <(echo -n) <(gofmt -d -s .)
diff -u <(echo -n) <(goimports -d .)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants