Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WindowTitle setting #14

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

nixpig
Copy link
Contributor

@nixpig nixpig commented Jul 24, 2024

Add grammar to parse WindowTitle setting. Per PR in vhs: charmbracelet/vhs#507

image

@nixpig nixpig force-pushed the set-window-title branch 2 times, most recently from 8b8572f to b01101b Compare August 23, 2024 15:17
@caarlos0 caarlos0 merged commit 7f165fd into charmbracelet:main Aug 23, 2024
@clason
Copy link
Contributor

clason commented Aug 24, 2024

This broke the parser -- did you generate it with an older version of tree-sitter? Then you would have had to downgrade the headers, too.

@clason
Copy link
Contributor

clason commented Aug 24, 2024

You really should set up workflows before you make any more changes...

caarlos0 added a commit that referenced this pull request Aug 24, 2024
caarlos0 added a commit that referenced this pull request Aug 24, 2024
@nixpig
Copy link
Contributor Author

nixpig commented Aug 25, 2024

This broke the parser -- did you generate it with an older version of tree-sitter? Then you would have had to downgrade the headers, too.

I generated it using the version of tree-sitter specified in dependencies - 0.20.8. So, yeah, an older version of tree-sitter than was required. My bad. I was supposed to upgrade this at the same time as the tests.

Apologies, and thank you for cleaning up the mess it caused 🤲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants