Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix lint on main #386

Merged
merged 1 commit into from
Oct 8, 2023
Merged

chore: Fix lint on main #386

merged 1 commit into from
Oct 8, 2023

Conversation

abhinav
Copy link
Contributor

@abhinav abhinav commented Oct 8, 2023

golangci-lint currently fails on main with:

command.go:6: File is not `goimports`-ed (goimports)
        "github.com/atotto/clipboard"
command.go:267:1: exported: exported function ExecuteCopy should have comment or be unexported (revive)
func ExecuteCopy(c Command, _ *VHS) {
^
command.go:271:1: exported: exported function ExecutePaste should have comment or be unexported (revive)
func ExecutePaste(_ Command, v *VHS) {
^

This fixes all three issues.

golangci-lint currently fails on main with:

```
command.go:6: File is not `goimports`-ed (goimports)
        "github.com/atotto/clipboard"
command.go:267:1: exported: exported function ExecuteCopy should have comment or be unexported (revive)
func ExecuteCopy(c Command, _ *VHS) {
^
command.go:271:1: exported: exported function ExecutePaste should have comment or be unexported (revive)
func ExecutePaste(_ Command, v *VHS) {
^
```

This fixes all three issues so that builds on main aren't red anymore.
@maaslalani
Copy link
Contributor

Thank you so much! We really appreciate the PR

@maaslalani maaslalani merged commit 8792438 into charmbracelet:main Oct 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants