Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warn when using SET commands not being the top decl #508

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat: warn when using SET commands not being the top decl #508

merged 2 commits into from
Oct 18, 2024

Conversation

Delta456
Copy link
Contributor

This PR adds a warning when using the SET commands after the top declaration.

Agreed, if a setting is ignored we should display a warning that this setting should appear at the top of the file!
Originally posted by @maaslalani in #503 (comment)

@Delta456 Delta456 requested a review from maaslalani as a code owner July 26, 2024 11:17
@bashbunni
Copy link
Member

Just tweaked the wording a bit. Thank you so much for the contribution :)
image

@bashbunni bashbunni merged commit 2ff7bbd into charmbracelet:main Oct 18, 2024
8 checks passed
@Delta456 Delta456 mentioned this pull request Oct 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 caarlos0 approved these changes

@maaslalani maaslalani Awaiting requested review from maaslalani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Delta456 @bashbunni @caarlos0