feat: Add slurm prometheus exporter to snapcraft.yaml recipe #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CPATH` must be set in build environment as the exporter uses `swig` to bind the Golang code to slurm/slurm.h Signed-off-by: Jason C. Nucciarone <[email protected]>
15 is the standard number used by HPC Engineering Signed-off-by: Jason C. Nucciarone <[email protected]>
Better than dozens of individual declarations for each command. If change needs to be made to the `slurm.conf` path, only one env var needs to be updated instead of many. Signed-off-by: Jason C. Nucciarone <[email protected]>
jedel1043
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the Slurm prometheus exporter into the snap image for Slurm. The part clones the exporter from GitHub and builds using
swigto bind to slurm/slurm.h. I also added a simple daemon for the exporter that can be started once all the other Slurm services have been started on the cluster.What still needs to be done
I need to add integration tests for the snap package in general. Testing can be done manually using a local LXD installation, but it would be great to have something that just sets up a minicluster and ensures that all the snap services + prometheus exporter are working. I will add this in a subsequent pull request; I've done something similar before here: https://nuccitheboss.github.io/cleantest/tutorials/using-a-mini-hpc-cluster/
Misc
SLURM_CONFas global environment variable rather than having it scoped individually to each command. Functionally it's similar to how it was defined before, but now if we need to update the location of the slurm.conf configuration file, we only have to change on value rather than dozens!