Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

feat: use slurm snap for slurmdbd operations #27

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

jedel1043
Copy link
Contributor

@jedel1043 jedel1043 commented Jul 22, 2024

Description

Uses the slurm_ops library to manage slurmdbd.
Adds support for running CI

How was the code tested?

Locally on an Ubuntu Jammy development machine.

Checklist

  • I am the author of these changes, or I have the rights to submit them.
  • I have added the relevant changes to the README and/or documentation.
  • I have self reviewed my own code.
  • All requested changes and/or review comments have been resolved.

A fix was applied because there was a bug on the way we deferred `_on_slurmctld_available`.
@jedel1043 jedel1043 changed the base branch from main to experimental July 22, 2024 23:31
@jedel1043 jedel1043 force-pushed the slurm-snap branch 3 times, most recently from 5b6cdbd to d846aca Compare July 23, 2024 22:37
@NucciTheBoss NucciTheBoss self-requested a review July 24, 2024 18:54
@NucciTheBoss
Copy link
Member

@jedel1043 is this still a draft PR, or is this ready for review? IIRC you mentioned this morning that this is the PR you want me to look over.

Side note: once we get everything initially working for COS, we'll begin the emigration back to a Slurm charm monorepo.

@jedel1043 jedel1043 marked this pull request as ready for review July 24, 2024 19:09
@jedel1043
Copy link
Contributor Author

@NucciTheBoss R4R

Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one small comment. Once it's addressed, I'll be good to merge this PR.

The systemd workaround for passing the MYSQL_UNIX_SOCKET will work for now, but we'll eventually want to spike on the proper way to solve this issue within slurmdbd. It'll either consist of patching Slurm directly to support setting a unix socket, or adding a configuration option to the snap itself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[foresight]: we can do this for now so that CI passes, but once we reassemble the monorepo after the COS integration work we should create a experimental workflow CI file.

src/constants.py Outdated Show resolved Hide resolved
We still need a `LegacySlurmdbdManager` until we figure out JWT and setting configs.
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🤩

@NucciTheBoss NucciTheBoss merged commit e2c6105 into charmed-hpc:experimental Jul 24, 2024
5 checks passed
@jedel1043 jedel1043 deleted the slurm-snap branch July 24, 2024 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants