-
Notifications
You must be signed in to change notification settings - Fork 7
feat: use slurm snap for slurmdbd operations #27
Conversation
A fix was applied because there was a bug on the way we deferred `_on_slurmctld_available`.
5b6cdbd
to
d846aca
Compare
@jedel1043 is this still a draft PR, or is this ready for review? IIRC you mentioned this morning that this is the PR you want me to look over. Side note: once we get everything initially working for COS, we'll begin the emigration back to a Slurm charm monorepo. |
@NucciTheBoss R4R |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just one small comment. Once it's addressed, I'll be good to merge this PR.
The systemd
workaround for passing the MYSQL_UNIX_SOCKET
will work for now, but we'll eventually want to spike on the proper way to solve this issue within slurmdbd. It'll either consist of patching Slurm directly to support setting a unix socket, or adding a configuration option to the snap itself.
.github/workflows/experimental.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[foresight]: we can do this for now so that CI passes, but once we reassemble the monorepo after the COS integration work we should create a experimental workflow CI file.
We still need a `LegacySlurmdbdManager` until we figure out JWT and setting configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful 🤩
Description
Uses the
slurm_ops
library to manage slurmdbd.Adds support for running CI
How was the code tested?
Locally on an Ubuntu Jammy development machine.
Checklist