fix: session feedback updates before release

chaynHQ · Jul 23, 2024 · 3c3f61a · 3c3f61a
1 parent 32c4de3
commit 3c3f61a
Show file tree

Hide file tree

Showing 8 changed files with 66 additions and 62 deletions.
diff --git a/components/forms/RateSessionForm.tsx b/components/forms/RateSessionForm.tsx
@@ -151,7 +151,11 @@ const RateSessionForm = (props: RateSessionFormProps) => {
           InputProps={{ disableUnderline: true }}
           InputLabelProps={{ shrink: true }}
         />
-        {formError && <Typography color="error.main">{formError}</Typography>}
+        {formError && (
+          <Typography sx={{ '&:last-of-type': { mb: 4 } }} color="error.main">
+            {formError}
+          </Typography>
+        )}
 
         <LoadingButton variant="contained" color="secondary" type="submit" loading={loading}>
           {t('sendButtonText')}

diff --git a/cypress/integration/user-course-session-behaviour.cy.tsx b/cypress/integration/user-course-session-behaviour.cy.tsx
@@ -47,7 +47,7 @@ describe.only('A logged in user should be able to navigate to a course session a
 
     cy.get('button').contains('Send').click(); //try to send feedback without selecting feedback option first
 
-    cy.get('p').contains('Please select a feedback option before submitting.').should('exist'); //give warning to user
+    cy.get('p').contains('Please select a rating before sending.').should('exist'); //give warning to user
 
     cy.get('input[name="session-feedback-radio-buttons"').first().check(); //click feedback option
 

diff --git a/messages/courses/de.json b/messages/courses/de.json
@@ -40,21 +40,21 @@
       "sessionComplete": "Session abgeschlossen"
     },
     "sessionFeedback": {
-      "title": "How was this session?",
-      "subtitle": "We’d love to hear how you found this session. Your feedback helps us to improve our courses.",
+      "title": "Wie war diese Session?",
+      "subtitle": "Wir würden gerne hören, wie Sie diese Sitzung gefunden haben. Ihr Feedback hilft uns, unsere Kurse zu verbessern.",
       "feedbackTags": {
-        "relatable": "Relatable",
-        "useful": "Useful",
-        "inspiring": "Inspiring",
-        "too long": "Too long",
-        "too complicated": "Too complicated",
-        "not useful": "Not useful"
+        "relatable": "Zuordenbar",
+        "useful": "Nützlich",
+        "inspiring": "Inspirierend",
+        "too long": "Zu lang",
+        "too complicated": "Zu kompliziert",
+        "not useful": "Nicht nützlich"
       },
-      "textboxDefaultText": "Add a comment...",
-      "sendButtonText": "Send",
-      "submissionText": "Thank you for submitting your feedback",
+      "textboxDefaultText": "Füge einen Kommentar hinzu...",
+      "sendButtonText": "Senden",
+      "submissionText": "Vielen Dank für die Übermittlung Ihres Feedbacks",
       "errors": {
-        "feedbackTagError": "Please select a feedback option before submitting."
+        "feedbackTagError": "Bitte wählen Sie vor dem Absenden eine Bewertung aus."
       }
     },
     "accessGuard": {

diff --git a/messages/courses/en.json b/messages/courses/en.json
@@ -54,7 +54,7 @@
       "sendButtonText": "Send",
       "submissionText": "Thank you for submitting your feedback",
       "errors": {
-        "feedbackTagError": "Please select a feedback option before submitting."
+        "feedbackTagError": "Please select a rating before sending."
       }
     },
     "accessGuard": {

diff --git a/messages/courses/es.json b/messages/courses/es.json
@@ -40,21 +40,21 @@
       "sessionComplete": "Sesión completa"
     },
     "sessionFeedback": {
-      "title": "How was this session?",
-      "subtitle": "We’d love to hear how you found this session. Your feedback helps us to improve our courses.",
+      "title": "¿Cómo fue esta sesión?",
+      "subtitle": "Nos encantaría saber cómo encontraste esta sesión. Tu opinión nos ayuda a mejorar nuestros cursos.",
       "feedbackTags": {
-        "relatable": "Relatable",
-        "useful": "Useful",
-        "inspiring": "Inspiring",
-        "too long": "Too long",
-        "too complicated": "Too complicated",
-        "not useful": "Not useful"
+        "relatable": "Relacionable",
+        "useful": "Útil",
+        "inspiring": "Inspirador",
+        "too long": "Demasiado largo",
+        "too complicated": "Demasiado complicado",
+        "not useful": "No útil"
       },
-      "textboxDefaultText": "Add a comment...",
-      "sendButtonText": "Send",
-      "submissionText": "Thank you for submitting your feedback",
+      "textboxDefaultText": "Añade un comentario...",
+      "sendButtonText": "Enviar",
+      "submissionText": "Gracias por enviar tu opinión",
       "errors": {
-        "feedbackTagError": "Please select a feedback option before submitting."
+        "feedbackTagError": "Por favor selecciona una calificación antes de enviar."
       }
     },
     "accessGuard": {

diff --git a/messages/courses/fr.json b/messages/courses/fr.json
@@ -40,21 +40,21 @@
       "sessionComplete": "Session complète"
     },
     "sessionFeedback": {
-      "title": "How was this session?",
-      "subtitle": "We’d love to hear how you found this session. Your feedback helps us to improve our courses.",
+      "title": "Comment avez-vous trouvé cette session ?",
+      "subtitle": "Nous aimerions connaître votre avis sur cette session. Vos retours nous aident à améliorer nos cours.",
       "feedbackTags": {
         "relatable": "Relatable",
-        "useful": "Useful",
-        "inspiring": "Inspiring",
-        "too long": "Too long",
-        "too complicated": "Too complicated",
-        "not useful": "Not useful"
+        "useful": "Utile",
+        "inspiring": "Inspirant",
+        "too long": "Trop long",
+        "too complicated": "Trop compliqué",
+        "not useful": "Pas utile"
       },
-      "textboxDefaultText": "Add a comment...",
-      "sendButtonText": "Send",
-      "submissionText": "Thank you for submitting your feedback",
+      "textboxDefaultText": "Ajouter un commentaire...",
+      "sendButtonText": "Envoyer",
+      "submissionText": "Merci d'avoir envoyé votre avis",
       "errors": {
-        "feedbackTagError": "Please select a feedback option before submitting."
+        "feedbackTagError": "Veuillez sélectionner une note avant d'envoyer."
       }
     },
     "accessGuard": {

diff --git a/messages/courses/hi.json b/messages/courses/hi.json
@@ -40,21 +40,21 @@
       "sessionComplete": "Session poora hua"
     },
     "sessionFeedback": {
-      "title": "How was this session?",
-      "subtitle": "We’d love to hear how you found this session. Your feedback helps us to improve our courses.",
+      "title": "Yeh session kaisa tha?",
+      "subtitle": "Hum aapke is session ke vichaar jaanna chahte hain. Aapka feedback humare courses ko behtar banane mein madad karta hai.",
       "feedbackTags": {
-        "relatable": "Relatable",
-        "useful": "Useful",
-        "inspiring": "Inspiring",
-        "too long": "Too long",
-        "too complicated": "Too complicated",
-        "not useful": "Not useful"
+        "relatable": "joda ja sakane vaala",
+        "useful": "upyogi",
+        "inspiring": "prerak",
+        "too long": "bahut lamba",
+        "too complicated": "bahut jatil",
+        "not useful": "anupyogi"
       },
-      "textboxDefaultText": "Add a comment...",
-      "sendButtonText": "Send",
-      "submissionText": "Thank you for submitting your feedback",
+      "textboxDefaultText": "Ek comment add karein...",
+      "sendButtonText": "Bhejein",
+      "submissionText": "Aapke feedback ko bhejne ke liye dhanyavaad",
       "errors": {
-        "feedbackTagError": "Please select a feedback option before submitting."
+        "feedbackTagError": "krpaya bhejane se pahale ek reting chunen."
       }
     },
     "accessGuard": {

diff --git a/messages/courses/pt.json b/messages/courses/pt.json
@@ -40,21 +40,21 @@
       "sessionComplete": "Sessão completa"
     },
     "sessionFeedback": {
-      "title": "How was this session?",
-      "subtitle": "We’d love to hear how you found this session. Your feedback helps us to improve our courses.",
+      "title": "Como foi esta sessão?",
+      "subtitle": "Adoraríamos saber como você achou esta sessão. Seu feedback nos ajuda a melhorar nossos cursos.",
       "feedbackTags": {
-        "relatable": "Relatable",
-        "useful": "Useful",
-        "inspiring": "Inspiring",
-        "too long": "Too long",
-        "too complicated": "Too complicated",
-        "not useful": "Not useful"
+        "relatable": "Relatável",
+        "useful": "Útil",
+        "inspiring": "Inspirador",
+        "too long": "Muito longo",
+        "too complicated": "Muito complicado",
+        "not useful": "Não útil"
       },
-      "textboxDefaultText": "Add a comment...",
-      "sendButtonText": "Send",
-      "submissionText": "Thank you for submitting your feedback",
+      "textboxDefaultText": "Adicione um comentário...",
+      "sendButtonText": "Enviar",
+      "submissionText": "Obrigado por enviar seu feedback",
       "errors": {
-        "feedbackTagError": "Please select a feedback option before submitting."
+        "feedbackTagError": "Por favor, selecione uma classificação antes de enviar."
       }
     },
     "accessGuard": {