Fix events dependencies (#777)

chaynHQ · Dec 20, 2023 · 615d7d0 · 615d7d0
1 parent 3d8e9ff
commit 615d7d0
Show file tree

Hide file tree

Showing 16 changed files with 16 additions and 23 deletions.
diff --git a/components/course/CourseHeader.tsx b/components/course/CourseHeader.tsx
@@ -1,10 +1,7 @@
 import { Button } from '@mui/material';
 import { ISbRichtext } from '@storyblok/react';
 import { useTranslations } from 'next-intl';
-import { useEffect } from 'react';
 import { PROGRESS_STATUS } from '../../constants/enums';
-import { COURSE_OVERVIEW_VIEWED } from '../../constants/events';
-import logEvent from '../../utils/logEvent';
 import Link from '../common/Link';
 import Header from '../layout/Header';
 
@@ -18,10 +15,6 @@ export interface CourseHeaderProps {
 const CourseHeader = (props: CourseHeaderProps) => {
   const { name, description, image_with_background, courseProgress, eventData } = props;
 
-  useEffect(() => {
-    logEvent(COURSE_OVERVIEW_VIEWED, eventData);
-  });
-
   const headerProps = {
     title: name,
     introduction: description,

diff --git a/components/crisp/CrispScript.tsx b/components/crisp/CrispScript.tsx
@@ -43,7 +43,7 @@ const CrispScript = () => {
         logEvent(CHAT_STARTED, eventUserData);
       },
     ]);
-  });
+  }, []);
 
   useEffect(() => {
     const hasLiveAccess =

diff --git a/components/storyblok/StoryblokCoursePage.tsx b/components/storyblok/StoryblokCoursePage.tsx
@@ -98,7 +98,7 @@ const StoryblokCoursePage = (props: StoryblokCoursePageProps) => {
 
   useEffect(() => {
     logEvent(COURSE_OVERVIEW_VIEWED, eventData);
-  });
+  }, []);
 
   const eventUserData = getEventUserData(userCreatedAt, partnerAccesses, partnerAdmin);
 

diff --git a/components/storyblok/StoryblokMeetTheTeamPage.tsx b/components/storyblok/StoryblokMeetTheTeamPage.tsx
@@ -76,7 +76,7 @@ const StoryblokMeetTheTeamPage = (props: StoryblokMeetTheTeamPageProps) => {
 
   useEffect(() => {
     logEvent(MEET_THE_TEAM_VIEWED, eventUserData);
-  });
+  }, []);
 
   const headerProps = {
     title: title,

diff --git a/components/storyblok/StoryblokSessionIbaPage.tsx b/components/storyblok/StoryblokSessionIbaPage.tsx
@@ -182,7 +182,7 @@ const StoryblokSessionIbaPage = (props: StoryblokSessionIbaPageProps) => {
 
   useEffect(() => {
     logEvent(SESSION_VIEWED, eventData);
-  });
+  }, []);
 
   const eventUserData = getEventUserData(userCreatedAt, partnerAccesses, partnerAdmin);
 

diff --git a/components/storyblok/StoryblokSessionPage.tsx b/components/storyblok/StoryblokSessionPage.tsx
@@ -213,7 +213,7 @@ const StoryblokSessionPage = (props: StoryblokSessionPageProps) => {
 
   useEffect(() => {
     logEvent(SESSION_VIEWED, eventData);
-  });
+  }, []);
 
   const eventUserData = getEventUserData(userCreatedAt, partnerAccesses, partnerAdmin);
   const eventData = {

diff --git a/guards/authGuard.tsx b/guards/authGuard.tsx
@@ -54,7 +54,7 @@ export function AuthGuard({ children }: { children: JSX.Element }) {
     });
 
     return () => unsubscribe();
-  });
+  }, []);
 
   // 2. Add ongoing event listener to check for token changes
   useEffect(() => {
@@ -67,7 +67,7 @@ export function AuthGuard({ children }: { children: JSX.Element }) {
         await dispatch(setUserToken(token));
       }
     });
-  });
+  }, []);
 
   // Function to get User details from the backend api
   async function callGetUser() {

diff --git a/guards/publicPageDataWrapper.tsx b/guards/publicPageDataWrapper.tsx
@@ -54,7 +54,7 @@ export function PublicPageDataWrapper({ children }: { children: JSX.Element }) {
       dispatch(setAuthStateLoading(false));
     });
     return () => unsubscribe();
-  });
+  }, []);
 
   useEffect(() => {
     async function callGetUser() {

diff --git a/pages/_app.tsx b/pages/_app.tsx
@@ -148,7 +148,7 @@ function AppReduxWrapper({ Component, ...rest }: MyAppProps) {
         (window as any).store = store;
       }
     }
-  });
+  }, []);
 
   return (
     <Provider store={store}>

diff --git a/pages/about-our-courses.tsx b/pages/about-our-courses.tsx
@@ -25,7 +25,7 @@ const CourseAbout: NextPage<Props> = ({ story }) => {
 
   useEffect(() => {
     logEvent(ABOUT_COURSES_VIEWED, eventUserData);
-  });
+  }, []);
 
   if (!story) {
     return <NoDataAvailable />;

diff --git a/pages/account/about-you.tsx b/pages/account/about-you.tsx
@@ -63,7 +63,7 @@ const AboutYou: NextPage = () => {
 
   useEffect(() => {
     logEvent(ABOUT_YOU_VIEWED, eventUserData);
-  });
+  }, []);
 
   const headerProps = {
     partnerLogoSrc: welcomeToBloom,

diff --git a/pages/account/apply-a-code.tsx b/pages/account/apply-a-code.tsx
@@ -63,7 +63,7 @@ const ApplyACode: NextPage = () => {
     const eventUserData = getEventUserData(userCreatedAt, partnerAccesses, partnerAdmin);
 
     logEvent(ASSIGN_NEW_PARTNER_VIEWED, eventUserData);
-  });
+  }, []);
 
   const headerProps = {
     title: t('applyCode.title'),

diff --git a/pages/admin/dashboard.tsx b/pages/admin/dashboard.tsx
@@ -34,7 +34,7 @@ const Dashboard: NextPage = () => {
 
   useEffect(() => {
     logEvent(CREATE_PARTNER_ACCESS_VIEWED, eventUserData);
-  });
+  }, []);
 
   return (
     <Box>

diff --git a/pages/partner-admin/create-access-code.tsx b/pages/partner-admin/create-access-code.tsx
@@ -36,7 +36,7 @@ const CreateAccessCode: NextPage = () => {
 
   useEffect(() => {
     logEvent(CREATE_PARTNER_ACCESS_VIEWED, { ...eventUserData });
-  });
+  }, []);
 
   return (
     <Box>

diff --git a/pages/therapy/book-session.tsx b/pages/therapy/book-session.tsx
@@ -102,7 +102,7 @@ const BookSession: NextPage = () => {
 
   useEffect(() => {
     logEvent(THERAPY_BOOKING_VIEWED, eventUserData);
-  });
+  }, []);
 
   const headerProps = {
     title: t('title'),

diff --git a/pages/therapy/confirmed-session.tsx b/pages/therapy/confirmed-session.tsx
@@ -44,7 +44,7 @@ const ConfirmedSession: NextPage = () => {
 
   useEffect(() => {
     logEvent(THERAPY_CONFIRMATION_VIEWED, eventUserData);
-  });
+  }, []);
 
   const headerProps = {
     title: t('confirmation.title'),