Add lighthouse performance Github Action #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link / number:
What changes did you make?
Adds the yml and config files required to enable the lighthouse-ci-action github action. The github action allows us to benchmark our lighthouse scores and fail PRs if scores drop below them on a new PR. The lighthouse report is also uploaded as an artifact to the PR, so we can easily review new performance scores.
Why did you make the changes?
As part of wider goal to improve Bloom performance, using lighthouse/page speed insights as the measurment tool.
Adding lighthouse performance testing as part of our CI workflow will allow us to see how the following PRs improve performance, without needing to manually restest several pages.
We may choose to reduce the frequency that lighthouse testing is completed (i.e. only run this github action on
mainPRs, as incypress-release-tests) following the performance updates.