Add failure if "Duplicate notifyFinishedToHarness()". (KhronosGroup#3311

) This ends up being an error in Firefox's harness, so let's prevent it upstream too.
chcunningham · Aug 11, 2021 · 12db127 · 12db127
1 parent 9ec0bd5
commit 12db127
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/sdk/tests/conformance/glsl/bugs/character-set.html b/sdk/tests/conformance/glsl/bugs/character-set.html
@@ -111,7 +111,5 @@
 var successfullyParsed = true;
 
 </script>
-<script src="../../../js/js-test-post.js"></script>
-
 </body>
 </html>
diff --git a/sdk/tests/js/js-test-pre.js b/sdk/tests/js/js-test-pre.js
@@ -112,6 +112,11 @@ function reportSkippedTestResultsToHarness(success, msg) {
 }
 
 function notifyFinishedToHarness() {
+  if (window._didNotifyFinishedToHarness) {
+    testFailed("Duplicate notifyFinishedToHarness()");
+  }
+  window._didNotifyFinishedToHarness = true;
+
   if (window.parent.webglTestHarness) {
     window.parent.webglTestHarness.notifyFinished(window.location.pathname);
   }