Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await risk sdk actions #535

Merged
merged 6 commits into from
May 30, 2024
Merged

Await risk sdk actions #535

merged 6 commits into from
May 30, 2024

Conversation

precious-ossai-cko
Copy link
Contributor

Issue

https://checkout.atlassian.net/browse/PRISM-11245

Proposed changes

Await acitons on the Risk SDK before continuing.

Test Steps

No changes in interaction or operation or test order.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Reviewers assigned
  • I have performed a self-review of my code and manual testing
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if applicable)

Further comments

NB: Regardless of success or failure within Risk, the completion handler is called on both scenarios.

NB: All asynchronous actions have a maximum timeout of 5 seconds.

@precious-ossai-cko precious-ossai-cko force-pushed the fix/await-risk-sdk-actions branch from 513ed0f to c48b535 Compare May 23, 2024 12:12
@okhan-okbay-cko okhan-okbay-cko marked this pull request as ready for review May 29, 2024 11:57
We needed a way to figure out client crashes for any unfinished risk SDK funnels
by comparing them to Frames' tokenisation success rate
@okhan-okbay-cko okhan-okbay-cko merged commit 40cd342 into main May 30, 2024
8 of 10 checks passed
@okhan-okbay-cko okhan-okbay-cko deleted the fix/await-risk-sdk-actions branch May 30, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants