-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Await risk sdk actions #535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
precious-ossai-cko
force-pushed
the
fix/await-risk-sdk-actions
branch
from
May 23, 2024 12:12
513ed0f
to
c48b535
Compare
okhan-okbay-cko
previously approved these changes
May 29, 2024
okhan-okbay-cko
had a problem deploying
to
AppStoreValidation
May 29, 2024 11:58 — with
GitHub Actions
Error
okhan-okbay-cko
temporarily deployed
to
AppStoreValidation
May 29, 2024 11:58 — with
GitHub Actions
Inactive
We needed a way to figure out client crashes for any unfinished risk SDK funnels by comparing them to Frames' tokenisation success rate
okhan-okbay-cko
added
Validate For App Store
and removed
Run Regression Tests
Validate For App Store
labels
May 29, 2024
okhan-okbay-cko
had a problem deploying
to
AppStoreValidation
May 29, 2024 13:23 — with
GitHub Actions
Error
okhan-okbay-cko
temporarily deployed
to
AppStoreValidation
May 29, 2024 13:23 — with
GitHub Actions
Inactive
okhan-okbay-cko
previously approved these changes
May 29, 2024
okhan-okbay-cko
added
Validate For App Store
and removed
Run Regression Tests
Validate For App Store
labels
May 29, 2024
okhan-okbay-cko
had a problem deploying
to
AppStoreValidation
May 29, 2024 14:58 — with
GitHub Actions
Error
okhan-okbay-cko
temporarily deployed
to
AppStoreValidation
May 29, 2024 14:58 — with
GitHub Actions
Inactive
okhan-okbay-cko
added
Validate For App Store
and removed
Run Regression Tests
Validate For App Store
labels
May 29, 2024
okhan-okbay-cko
had a problem deploying
to
AppStoreValidation
May 29, 2024 15:18 — with
GitHub Actions
Error
okhan-okbay-cko
temporarily deployed
to
AppStoreValidation
May 29, 2024 15:18 — with
GitHub Actions
Inactive
okhan-okbay-cko
previously approved these changes
May 29, 2024
okhan-okbay-cko
added
Validate For App Store
and removed
Run Regression Tests
Validate For App Store
labels
May 29, 2024
okhan-okbay-cko
had a problem deploying
to
AppStoreValidation
May 29, 2024 15:24 — with
GitHub Actions
Error
okhan-okbay-cko
temporarily deployed
to
AppStoreValidation
May 29, 2024 15:24 — with
GitHub Actions
Inactive
ehab-al-cko
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://checkout.atlassian.net/browse/PRISM-11245
Proposed changes
Await acitons on the Risk SDK before continuing.
Test Steps
No changes in interaction or operation or test order.
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NB: Regardless of success or failure within Risk, the completion handler is called on both scenarios.
NB: All asynchronous actions have a maximum timeout of 5 seconds.