Merge pull request #38 from checkr/fix-package-return-packages

Fix packages

Changelog.md

@@ -1,4 +1,4 @@
-## 1.3.0 (2018-01-19)
+## 1.3.1 (2018-01-19)
 
 Features:
 

lib/checkr/package.rb

@@ -6,7 +6,7 @@ class Package < APIResource
     attribute :price
     attribute :screenings
 
-    api_class_method :all, :get, :constructor => APIList.constructor(:Geo)
+    api_class_method :all, :get, :constructor => APIList.constructor(:Package)
     api_class_method :retrieve, :get, ":path/:id", :arguments => [:id]
     api_class_method :create, :post
 

lib/checkr/program.rb

@@ -11,7 +11,6 @@ class Program < APIResource
 
     api_class_method :all, :get, :constructor => APIList.constructor(:Program)
     api_class_method :retrieve, :get, ":path/:id", :arguments => [:id]
-    api_class_method :create, :post
 
     def self.path
       "/v1/programs"

lib/checkr/version.rb

@@ -1,3 +1,3 @@
 module Checkr
-  VERSION = '1.3.0'.freeze
+  VERSION = '1.3.1'.freeze
 end

test/checkr/package_test.rb

@@ -73,6 +73,14 @@ class PackageTest < Test::Unit::TestCase
       end
     end
 
+    context '#all' do
+      should 'return instances of Package' do
+        @mock.expects(:get).once.with(@package_url, anything, anything)
+            .returns(test_response(test_package_list))
+        assert_equal(Package.all.first.class, Package)
+      end
+    end
+
     should 'be registered' do
       assert(APIClass.subclasses.include?(Package))
       assert_equal(Package, APIClass.subclass_fetch('package'))

test/checkr/program_test.rb

@@ -14,14 +14,6 @@ class ProgramTest < Test::Unit::TestCase
         program = Program.retrieve(id)
         assert(program.is_a?(Program))
       end
-
-      should 'be createable' do
-        @mock.expects(:post).once.with(@program_url, anything, test_program)
-          .returns(test_response(test_program))
-        program = Program.create(test_program)
-        assert(program.is_a?(Program))
-        assert_equal(program.id, test_program[:id])
-      end
     end
 
     context 'Program instance' do
@@ -80,6 +72,14 @@ class ProgramTest < Test::Unit::TestCase
       end
     end
 
+    context '#all' do
+      should 'return instances of Program' do
+        @mock.expects(:get).once.with(@program_url, anything, anything)
+            .returns(test_response(test_program_list))
+        assert_equal(Program.all.first.class, Program)
+      end
+    end
+
     should 'be registered' do
       assert(APIClass.subclasses.include?(Program))
       assert_equal(Program, APIClass.subclass_fetch('program'))

test/test_data.rb

@@ -140,6 +140,13 @@ def test_package
            :subtype=>"7years"}]}
     end
 
+    def test_package_list
+      {
+        :object => 'list',
+        :data => [test_package, test_package, test_package],
+      }
+    end
+
     def test_program
       {:id=>"e44aa283528e6fde7d542194",
        :object=>"program",
@@ -150,6 +157,13 @@ def test_program
        :package_ids=>["a57a0cd15965a585ff7d5d35"]}
     end
 
+    def test_program_list
+      {
+        :object => 'list',
+        :data => [test_program, test_program, test_program],
+      }
+    end
+
     def test_ssn_trace
       {:id=>"539fd88c101897f7cd000001",
        :object=>"ssn_trace",