Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maps column view to allow the use of placeholders #119

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from

Conversation

ryanmortier
Copy link
Contributor

FilamentGoogleMaps\Columns\MapColumn::make('coordinates')
    ->label('Map')
    ->type('hybrid')
    ->alignCenter()
    ->zoom(14)
    ->height(100)
    ->width(150)
    ->placeholder(fn (): HtmlString => new HtmlString('—')),

Preview:

CleanShot 2024-08-27 at 19 29 11

Heyian added a commit to Heyian/filament-google-maps that referenced this pull request Aug 28, 2024
See Pull Request cheesegrits#119 on original repo from ryanmortier
Heyian added a commit to Heyian/filament-google-maps that referenced this pull request Aug 28, 2024
See Pull Request cheesegrits#119 on original repo from ryanmortier
@Heyian
Copy link
Collaborator

Heyian commented Aug 28, 2024

Hey there. I've merged this PR onto my fork so we can all get all these goodies from a single place. I gave credits to the person who made the PR in the commits, changelog and in the releases.
I've also credited cheesegrits for his work on the repo and made it clear this was a fork on top of the Readme. I'm not trying to hijack anything, I just want to be able to use all the good solutions people put in the pull requests and I thought I'd made this available to all. If you're interested in this version or want to contribute, you can find my fork at : Heyian/forkMain

I'm open to suggestions on how to move forward from here, simply open up an issue in my fork so we can chat about it.
Thanks.

@cheesegrits
Copy link
Owner

@ryanmortier

Hey, I'm working with @Heyian to get this package whipped back in to shape. I've had some serious medical issues this year which have kept me from working on it, but I'm recovered now.

Thanks for the PR.

Can you update the README to document this, then I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants