Add Docker and SystemD support to runit. #60
Conversation
While we are at it, stop detecting the init system by distro type and version number, and check it heuristically by the filesystem structures that are unique to each init system, while assuming that Docker containers won't have a working init no matter what we would otherwise detect. Extending this to other init schemes and container types is left as an exercise for the annoyed sysadmin.
|
|
||
| [Service] | ||
| ExecStart=/opt/chef-server/embedded/bin/runsvdir-start | ||
| ExecStopPost=pkill -HUP -P 1 runsv$$ |
There was a problem hiding this comment.
What would you be running to start the server inside Docker? "docker run what?"
There was a problem hiding this comment.
Well, not the systemd unit for starters. :) Look at files/chef-server-cookbooks/runit/recipes/default.rb. It should be obvious.
There was a problem hiding this comment.
IMO we need to pull in the community runit cookbook like we do for Enterprise Chef. This would ensure any fixes we make benefit everyone using that cookbook (runit). /cc @mmzyk
|
@VictorLowther This is good stuff. It would be best to add any changes Runit-related SystemD/Docker fixes into the community Runit cookbook. We will begin leveraging that cookbook in this code base in the not so distant future. |
|
@btm The best person is probably @marcparadise. Now he'll know this PR exists. @VictorLowther Thanks for this PR. Unfortunately we're in bug fix mode for the upcoming release, 11.1, but we'll look to get this incorporated into the release after that. We also realize that it's taken us unacceptably long to get 11.1 out the door. We're working on reducing the lag between releases, as we don't want work like this to just sit in PRs forever. |
|
/cc @tduffield |
|
Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA. The following GitHub users do not appear to have signed a CLA: |
1 similar comment
|
Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA. The following GitHub users do not appear to have signed a CLA: |
|
Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future. |
While we are at it, stop detecting the init system by distro type and
version number, and check it heuristically by the filesystem structures
that are unique to each init system, while assuming that Docker
containers won't have a working init no matter what we would otherwise
detect.
Extending this to other init schemes and container types is left as an
exercise for the annoyed sysadmin.