Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the opensuse build for different providers #1591

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dydoc
Copy link

@dydoc dydoc commented Dec 22, 2024

Description

The PR will fix builds for Opensuse distribution for several providers and archs:

  • Parallels: the build is completely fixed
  • VirtualBox: the build only fails during the export phase for the arch aarch64 because of a bug in Virtualbox export

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@dydoc dydoc requested review from Stromweld and a team as code owners December 22, 2024 16:38
@dydoc dydoc changed the title fixing the opensuse build for different provider fixing the opensuse build for different providers Dec 22, 2024
@Stromweld
Copy link
Collaborator

Why are you skipping guest tools install if it's aarch64 system?

@dydoc
Copy link
Author

dydoc commented Dec 22, 2024

Why are you skipping guest tools install if it's aarch64 system?

the guest tools in both cases (Parallels and Virtualbox) don't compile against the current OpenSUSE kernels.

@dydoc
Copy link
Author

dydoc commented Dec 25, 2024

Why are you skipping guest tools install if it's aarch64 system?

the guest tools in both cases (Parallels and Virtualbox) don't compile against the current OpenSUSE kernels.

@Stromweld any feedback on my response?

@Stromweld
Copy link
Collaborator

Stromweld commented Dec 26, 2024

That makes sense, but the way it's edited it wont build them them for any OS with aarch64. I know they work for some systems.

@dydoc
Copy link
Author

dydoc commented Dec 26, 2024

That makes sense, but the way it's edited it wont build them them for any OS with aarch64. I know they work for some systems.

good call @Stromweld : I modified the condition to exclude only opensuse and derivative for aarch64. I'm looking forward to other feedback from you.

…dition : skipping only for opensuse and suse for aarch64

Signed-off-by: Nicolino Curalli <[email protected]>
Signed-off-by: Nicolino Curalli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants