-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing the opensuse build for different providers #1591
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nicolino Curalli <[email protected]>
Signed-off-by: Nicolino Curalli <[email protected]>
Signed-off-by: Nicolino Curalli <[email protected]>
Signed-off-by: Nicolino Curalli <[email protected]>
Why are you skipping guest tools install if it's aarch64 system? |
the guest tools in both cases (Parallels and Virtualbox) don't compile against the current OpenSUSE kernels. |
@Stromweld any feedback on my response? |
That makes sense, but the way it's edited it wont build them them for any OS with aarch64. I know they work for some systems. |
good call @Stromweld : I modified the condition to exclude only opensuse and derivative for aarch64. I'm looking forward to other feedback from you. |
…dition : skipping only for opensuse and suse for aarch64 Signed-off-by: Nicolino Curalli <[email protected]>
Signed-off-by: Nicolino Curalli <[email protected]>
Quality Gate passedIssues Measures |
Description
The PR will fix builds for Opensuse distribution for several providers and archs:
Related Issue
Types of changes
Checklist:
Gemfile.lock
has changed, I have used--conservative
to do it and included the full output in the Description above.