Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yaml load error for ruby 3.1 #220

Merged
merged 11 commits into from
Apr 25, 2023
Merged

Fix yaml load error for ruby 3.1 #220

merged 11 commits into from
Apr 25, 2023

Conversation

Stromweld
Copy link
Contributor

@Stromweld Stromweld commented Apr 20, 2023 •
edited
Loading

Description

Ruby 3.1 changed the way YAML load works. See issue #218 for more details

Related Issue

#218

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@Stromweld
Fix yaml load error for ruby 3.1
789ad8c
@Stromweld
update ruby versions
6b73e69 
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld
fix rspec mocks for hash with keywords in ruby 3.0+
1c3aa7d 
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld
test
8f4e96f 
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld
test
e81ef1c 
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld
test
b4dd17f 
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld
test
90ca020 
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld
test
4344c9b 
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld Stromweld marked this pull request as ready for review April 20, 2023 21:36
@Stromweld Stromweld requested review from a team as code owners April 20, 2023 21:36
@Stromweld
test
61aeb3c 
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld
Copy link
Contributor Author

I don't have access to merge so if you could merge this when you get the chance that'd be great.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vkarve-chef vkarve-chef merged commit b0f946a into chef:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarve-chef vkarve-chef vkarve-chef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stromweld @vkarve-chef