feat: improve 1D line broadening filter #8047
jobo322nodejs.yml
on: pull_request
nodejs
/
prepare
17s
stylelint
35s
nodejs
/
lint-eslint
4m 5s
nodejs
/
lint-prettier
35s
nodejs
/
lint-check-types
3m 34s
Matrix: nodejs / test
Annotations
12 errors and 10 warnings
|
nodejs / lint-check-types:
src/component/panels/MatrixGenerationPanel/MatrixGenerationPanel.tsx#L79
The inferred type of 'useHasSignalProcessingFilter' cannot be named without a reference to 'nmr-load-save/node_modules/nmr-processing'. This is likely not portable. A type annotation is necessary.
|
|
nodejs / lint-check-types
Process completed with exit code 2.
|
|
nodejs / lint-eslint:
src/component/1d-2d/components/SpectrumInfoBlock.tsx#L48
Switch is not exhaustive. Cases not matched: "bigint" | "symbol" | "undefined" | "object" | "function"
|
|
nodejs / lint-eslint:
src/component/1d-2d/components/SpectrumInfoBlock.tsx#L108
Switch is not exhaustive. Cases not matched: null
|
|
nodejs / lint-eslint:
src/component/1d/Viewer1D.tsx#L171
Switch is not exhaustive. Cases not matched: "shift[true]_ctrl[false]_alt[false]" | "shift[false]_ctrl[false]_alt[false]" | "shift[false]_ctrl[true]_alt[false]" | "shift[false]_ctrl[true]_alt[true]" | "shift[true]_ctrl[false]_alt[true]" | "shift[true]_ctrl[true]_alt[false]" | "shift[true]_ctrl[true]_alt[true]"
|
|
nodejs / lint-eslint:
src/component/1d/Viewer1D.tsx#L174
Switch is not exhaustive. Cases not matched: "zoom" | "zoomOut" | "import" | "exportAs" | "spectraStackAlignments" | "spectraCenterAlignments" | "realImaginary" | "peakPicking" | "integral" | "zonePicking" | "slicing" | "rangePicking" | "zeroFilling" | "apodization" | "phaseCorrection" | "phaseCorrectionTwoDimensions" | "baselineCorrection" | "fft" | "fftDimension1" | "fftDimension2" | "multipleSpectraAnalysis" | "exclusionZones" | "autoRangeAndZonePicking" | "HMove" | "equalizer" | "generalSelector" | "databaseRangesSelection" | "matrixGenerationExclusionZones"
|
|
nodejs / lint-eslint:
src/component/1d/Viewer1D.tsx#L261
Switch is not exhaustive. Cases not matched: "zoom" | "zoomOut" | "import" | "exportAs" | "spectraStackAlignments" | "spectraCenterAlignments" | "realImaginary" | "peakPicking" | "integral" | "zonePicking" | "slicing" | "rangePicking" | "zeroFilling" | "apodization" | "phaseCorrection" | "phaseCorrectionTwoDimensions" | "baselineCorrection" | "fft" | "fftDimension1" | "fftDimension2" | "multipleSpectraAnalysis" | "exclusionZones" | "autoRangeAndZonePicking" | "HMove" | "equalizer" | "generalSelector" | "databaseRangesSelection" | "matrixGenerationExclusionZones"
|
|
nodejs / lint-eslint:
src/component/1d/Viewer1D.tsx#L356
Switch is not exhaustive. Cases not matched: "shift[true]_ctrl[false]_alt[false]" | "shift[false]_ctrl[false]_alt[false]" | "shift[false]_ctrl[false]_alt[true]" | "shift[false]_ctrl[true]_alt[false]" | "shift[false]_ctrl[true]_alt[true]" | "shift[true]_ctrl[false]_alt[true]" | "shift[true]_ctrl[true]_alt[false]" | "shift[true]_ctrl[true]_alt[true]"
|
|
nodejs / lint-eslint:
src/component/1d/Viewer1D.tsx#L358
Switch is not exhaustive. Cases not matched: "zoomOut" | "import" | "exportAs" | "spectraStackAlignments" | "spectraCenterAlignments" | "realImaginary" | "zonePicking" | "slicing" | "zeroFilling" | "apodization" | "phaseCorrectionTwoDimensions" | "baselineCorrection" | "fft" | "fftDimension1" | "fftDimension2" | "multipleSpectraAnalysis" | "exclusionZones" | "autoRangeAndZonePicking" | "HMove" | "equalizer" | "generalSelector" | "databaseRangesSelection"
|
|
nodejs / lint-eslint:
src/component/1d/peaks/PeakAnnotationsSpreadMode.tsx#L35
Switch is not exhaustive. Cases not matched: null
|
|
nodejs / lint-eslint:
src/component/2d/FooterBanner.tsx#L95
Switch is not exhaustive. Cases not matched: null
|
|
nodejs / lint-eslint:
src/component/2d/FooterBanner.tsx#L125
Switch is not exhaustive. Cases not matched: null
|
|
nodejs / lint-eslint:
eslint.config.js#L29
Unexpected 'todo' comment: 'todo remove the following rules once...'
|
|
nodejs / lint-eslint:
src/component/assignment/index.tsx#L31
Unexpected 'todo' comment: 'TODO: Fix this type error. It's been...'
|
|
nodejs / lint-eslint:
src/component/elements/Alert.tsx#L139
Do not use Array index in keys
|
|
nodejs / lint-eslint:
src/component/elements/Button.tsx#L1
Unexpected 'todo' comment: 'TODO resolve the eslint rules'
|
|
nodejs / lint-eslint:
src/component/elements/InputRange.tsx#L39
Unexpected 'todo' comment: 'TODO: remove this hacky ref usage.'
|
|
nodejs / lint-eslint:
src/component/elements/NumberInput2Controller.tsx#L19
Capture group '(\.\d+)' should be converted to a named or non-capturing group
|
|
nodejs / lint-eslint:
src/component/hooks/useFilter.ts#L7
There should be at least one empty line between import groups
|
|
nodejs / lint-eslint:
src/component/hooks/useFilter.ts#L8
`../../data/types/common/ExtractFilterEntry.js` type import should occur before type import of `../../data/types/common/FilterEntry.js`
|
|
nodejs / lint-eslint:
src/component/modal/MultipletAnalysisModal.tsx#L175
Unexpected 'todo' comment: 'TODO: handle error'
|
|
nodejs / lint-eslint:
src/component/modal/setting/settings-tabs/OnLoadProcessingTabContent.tsx#L13
`../../../../data/getFilterLabel.js` import should occur before import of `../../../elements/IsotopesViewer.js`
|