Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to vertical move the peaks #3112

Closed
lpatiny opened this issue Jul 5, 2024 · 3 comments · Fixed by #3270 · May be fixed by #3218
Closed

Add possibility to vertical move the peaks #3112

lpatiny opened this issue Jul 5, 2024 · 3 comments · Fixed by #3270 · May be fixed by #3218
Assignees
Labels
enhancement New feature or request

Comments

@lpatiny
Copy link
Member

lpatiny commented Jul 5, 2024

When peaks are at the top, we should be able to determine the position from the top of the screen. This could be achieved either with a vertical move of the entire block or, if problematic, by changing a preference.

This is applicable when displaying the peaks in the range, as well as in the case of peak picking. It might be better to have two different preferences.

@hamed-musallam
Copy link
Member

hamed-musallam commented Aug 13, 2024

Hello Luc @lpatiny

Should these preferences be set per Nucleus or spectrum? in the ranges and peaks preferences?

@lpatiny
Copy link
Member Author

lpatiny commented Aug 28, 2024

This could be done globally. No need to do it by nucleus.

@hamed-musallam
Copy link
Member

@hamed-musallam hamed-musallam linked a pull request Oct 16, 2024 that will close this issue
hamed-musallam added a commit that referenced this issue Oct 18, 2024
close #3112

feat: interactive positioning of peak labels
@github-project-automation github-project-automation bot moved this from 🔴 Todo to 🟢 Done in NMR and Cheminfo projects organisation Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
2 participants