feat: control the margin top of the peaks label #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nmrium with
|
| Latest commit: |
3a02ad9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://44d2a04f.nmrium.pages.dev |
| Branch Preview URL: | https://peaks-label-margin-top.nmrium.pages.dev |
targos
reviewed
Oct 16, 2024
|
Do you need feedback from Luc or we can merge this? I'd like to finish #3271 this morning |
|
I'm waiting for Luc's feedback before merging (Which I prefer), but if you're in a hurry, we can go ahead and merge it now and make improvements later. |
lpatiny
approved these changes
Oct 18, 2024
close #3112 feat: interactive positioning of peak labels
hamed-musallam
force-pushed
the
peaks-label-margin-top
branch
from
0b9d3d8 to
3a02ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.