pass logger to filter for time consuming information #3296
Conversation
Deploying nmrium with
|
| Latest commit: |
f2f6772
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://65de4cd2.nmrium.pages.dev |
| Branch Preview URL: | https://pass-log-for-time-consuming.nmrium.pages.dev |
jobo322
force-pushed
the
pass-log-for-time-consuming-filter-22-11-1023
branch
from
176128e
to
9a5936a
Compare
jobo322
force-pushed
the
pass-log-for-time-consuming-filter-22-11-1023
branch
from
98fe26b
to
f2f6772
Compare
| @@ -176,6 +178,7 @@ function KeysListenerTracker(props: KeysListenerTrackerProps) { | |||
| type: 'DELETE_EXCLUSION_ZONE', | |||
| payload: { | |||
| zone, | |||
| logger, | |||
| }, | |||
There was a problem hiding this comment.
We need to ensure the reducer function remains pure. Passing the logger to the reducer introduces a side effect, which we should avoid. This issue has been consistently repeated across all the PRs you submitted
There was a problem hiding this comment.
we should lift the function up that requires the logger as a parameter to the callback function and pass its result down to the reducer
There was a problem hiding this comment.
We have a reducer that for example apply apodization on a spectrum. Apodization being done by nmr-processing.
We would like that nmr-processing can log some information (time spend in each filter) in the logger.
Problem is that the logger is changing another part of the state and this is not expected to be done in a reducer.
@targos Do you have some suggestions how to solve this issue ?
There was a problem hiding this comment.
Hamed said it all. You need to do the processing outside of the reducer and send the result to the reducer. A reducer is not supposed to do heavy work. Just take some data and update the state with it.
No description provided.