Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just some code refactoring to make the code more clean and readable. #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Just some code refactoring to make the code more clean and readable. #14

wants to merge 1 commit into from

Conversation

andreasonny83
Copy link

I hope you'll appreciate some code refactoring and code optimisation.

@cheonhyangzhang
Copy link
Owner

Thanks for the changes for refactoring and code opt.
Sorry that I was focusing another feature #12, forgot this pull request and pushed changes to the master branch which made this pull request out of date.

If you don't mind I will do the refactoring in later changes.

@andreasonny83
Copy link
Author

Sure, don't worry. I will have a look at the latest commit and perform a code optimisation according to that.
I made some improvements in my local version you would probably like to have in your repository as well.
I will send you a new pull request soon. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreasonny83 @cheonhyangzhang