Sort the members with overdue items report by most overdue and add borrow policy filters #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim
approved these changes
Oct 29, 2024
crismali
force-pushed
the
michael-1636-and-1635-members-with-overdue-tools-report
branch
from
a339dc9
to
752742a
Compare
crismali
deleted the
michael-1636-and-1635-members-with-overdue-tools-report
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This changes the members with overdue items report to:
Why it is important
#1635 and #1636
UI Change Screenshot
The report with no filters active ("All"):
The report with an active filter:
Implementation notes
Maybe there's a better way to get everything out in a single activerecord query (ie without
in) so I'm open to suggestions but this works pretty well.