Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added renewal count to the renewal requests index page #1740

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

crismali
Copy link
Contributor

@crismali crismali commented Nov 8, 2024

What it does

Added the renewal count to the renewal requests index page and rearranged a few of the columns.

Why it is important

#1654

UI Change Screenshot

The renewal requests index page on a iPad mini
Screenshot 2024-11-08 at 3 28 23 PM

Implementation notes

If this page needs to support a narrower screen size we can combine some of the columns but the iPad mini (768px wide in portrait mode) seems like it would cover most devices. Let me know if not!

Copy link
Member

@jim jim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think folks mostly access this on laptops/desktops but we can check with staff to see if that assumption is incorrect.

@jim jim merged commit 5aad981 into main Nov 9, 2024
9 checks passed
@jim jim deleted the michael-1654-renewal-count-on-renewal-requests-page branch November 9, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants