Disable the maintenance option when creating an item #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim
reviewed
Nov 15, 2024
crismali
force-pushed
the
michael-1743-require-a-ticket-to-set-an-item-to-in-maintenance
branch
from
f892c35
to
df59571
Compare
crismali
commented
Nov 16, 2024
| @@ -50,6 +52,11 @@ def category_nav(categories, current_category = nil) | |||
| end | |||
| end | |||
|
|
|||
| def status_hint(item) | |||
There was a problem hiding this comment.
Originally I just did this in the template, but erb_lint didn't like me using html_safe there. Standard is okay with it though 🤷
crismali
commented
Nov 16, 2024
| @@ -28,7 +28,7 @@ | |||
| "devDependencies": { | |||
| "concurrently": "^9.1.0", | |||
| "markdown-toc": "^1.2.0", | |||
| "playwright": "1.46.0", | |||
| "playwright": "1.45.0", | |||
There was a problem hiding this comment.
I pulled this down a version because this needs to be in sync with the gem, but sometimes dependabot slips an update through
jim
approved these changes
Nov 19, 2024
Comment on lines
+50
to
+53
| def update_item_status!(ticket) | ||
| status = ticket.retired? ? Item.statuses["retired"] : Item.statuses["maintenance"] | ||
| @ticket.item.update!(status:) | ||
| end |
There was a problem hiding this comment.
I wonder if there is a workflow where staff would want to create a ticket without putting an item into maintenance? Let's merge this as-is but check in at the next stakeholders about this.
crismali
deleted the
michael-1743-require-a-ticket-to-set-an-item-to-in-maintenance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Disables the maintenance option on the admin item form and marks items as in maintenance after creating a ticket.
Why it is important
#1743
UI Change Screenshot
Select dropdown for a new item:
Select dropdown when editing an item:
Expanded select dropdown when editing an item:
An item just before creating a ticket:
An item right after creating a ticket:
Implementation notes
For now I've set it up to only put items into maintenance when creating a ticket. I could see a case for marking items as available once the ticket is resolved, but I can also imagine reasons we might not want that to happen (maybe another ticket was created afterwards or that issue is resolved because it's lost now or something).