Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return items on a reservation #1764

Merged
merged 9 commits into from
Nov 25, 2024
Merged

Return items on a reservation #1764

merged 9 commits into from
Nov 25, 2024

Conversation

jim
Copy link
Member

@jim jim commented Nov 19, 2024

What it does

  • Adds the ability for a staff member to mark items on a reservation as returned at the end of a loan.
  • Restructures the "Pickups" tab to be the "Items" tab on a reservation. Now all item manipulation (both while building up the specific items to be borrowed and when they are returned later on) happen on the same page/tab.
  • Deletes an unused partial: app/views/account/reservations/_profile.html.erb.

Why it is important

We need to have a accept items that are returned to us 😄

UI Change Screenshot

2024-11-19 18 36 54

Implementation notes

@jim jim requested a review from a team November 20, 2024 03:02
@jim jim marked this pull request as ready for review November 20, 2024 03:02
Copy link
Contributor

@crismali crismali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full turbo 🔥

@jim jim merged commit cd5792c into main Nov 25, 2024
9 checks passed
@jim jim deleted the jim-returning-items branch November 25, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants