Add RTL file list to be modified by integrators #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitsirks
previously approved these changes
Jan 8, 2024
nquarton
previously approved these changes
Jan 8, 2024
steph-morton
reviewed
Jan 8, 2024
steph-morton
previously approved these changes
Jan 10, 2024
nquarton
previously approved these changes
Jan 10, 2024
nquarton
previously approved these changes
Jan 12, 2024
steph-morton
approved these changes
Jan 12, 2024
andreslagarcavilla
requested review from
nquarton,
mcockrell-google and
howardtr
nquarton
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #358 by adding a table to the Integration spec that describes which RTL modifications integrators are expected to make.
Several other issues in the caliptra-rtl repository also discuss concerns over ambiguous synchronizer requirements and implementation:
This update may become obsolete and require further spec updates once chipsalliance/Cores-VeeR-EL2#56 has been finalized and merged back into the caliptra-rtl repository.
Resolves #333
Resolves #358