Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added license headers to verilog files #65

Closed
wants to merge 2 commits into from

Conversation

jaromharris
Copy link
Collaborator

I added license headers to the verilog files due to the updated SymbiFlow/actions/checks that checks for license headers.

@jgoeders
Copy link
Contributor

jgoeders commented Jun 8, 2021

Hmm, this is failing because they are golden test files, and the output of fasm2bels isn't going to add the license header, so the files are no longer equal.

@mithro It probably doesn't make sense to have license headers on golden test files. Let me know if you feel otherwise.

@jaromharris https://github.com/SymbiFlow/actions/tree/main/checks says that:

Excluding files
Files can be excluded from the license checks using the exclude_license input.

Can you do that instead for these test files?

GitHub
GitHub Actions to be reused in CI workflows. Contribute to SymbiFlow/actions development by creating an account on GitHub.

@mithro
Copy link
Contributor

mithro commented Jun 8, 2021

@jgoeders -- We should probably mark the files as generated using linguist - f4pga/actions#27 which is pending on github-linguist/linguist#5382

@jgoeders
Copy link
Contributor

jgoeders commented Jun 8, 2021

@jaromharris Sorry, you probably didn't see mithro's comment. Rather than updating ci.yml, can you instead mark the files as generated: https://github.com/github/linguist/blob/master/docs/overrides.md#generated-code, then hopefully SymbiFlow/actions/checks will be updated soon to automatically not check these.

GitHub
Language Savant. If your repository's language is being reported incorrectly, send us a pull request! - github/linguist

@jaromharris
Copy link
Collaborator Author

Can you let me know that I did that correctly?

@jgoeders
Copy link
Contributor

jgoeders commented Jun 9, 2021

This looks good. You could do it by wildcard, but there aren't too many files, and for license exceptions, it's perhaps better to spell them out individually.

… with files marked as generated

Signed-off-by: Jarom Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants