Fixed Bug with shell and shellArgs being callbacks #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a fix so that shell and shellArgs can be callbacks
risacher
referenced
this pull request
in risacher/ttyx
Apr 14, 2017
Improve user-example.js Accept PR chjj#90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this feature request and attempted to use it: #62
I received some errors upon using the example provided. There are pieces of logic in the
config.jsandtty.jsthat expectshellandshellArgsto be of typestring. I have updated the logic to not perform string operations when the two properties are functions.