Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test codescanning alert behavior2 #49

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chmeliik
Copy link
Owner

  • test: hardcode rule in sarif output
  • test: introduce warning

chmeliik added 2 commits July 19, 2024 12:50
is this why the alert is not disappearing?
Signed-off-by: Adam Cmiel <[email protected]>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@@ -25,7 +25,7 @@
image_without_digest=${image%@*}
version=${image_without_digest##*:}

if [[ "$tag" != "$version" ]]; then
if [[ $tag != $version ]]; then

Check warning

Code scanning / shellcheck

SC2053 Warning

Quote the right-hand side of != in [[ ]] to prevent glob matching.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, nope, the missing rules property is not why the alert is not disappearing :(

Signed-off-by: Adam Cmiel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant