Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(librecad) Switch to using new GitHub API helper #2195

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

AdmiringWorm
Copy link
Member

Description

This pull request updates the automatic updater to make use of our new GitHub API helper to get the releases available.
This allows this package to once again be pushed to Chocolatey Community Repository.

Additionally, a small change to include the already pushed versions of 2.1 and 2.0 has been added, without having these added and if we need to create a fix version we would first need to add these manually or explicitly set the version to use.

fixes #2194

Motivation and Context

To make the automatic updater work again.

How Has this Been Tested?

  1. Run .\update_all.ps1 librecad
  2. Verify a package was created for 2.2.0
  3. Run .\update_all.ps1 librecad -ForcedPackages librecad\2.1
  4. Verify a fix version for version 2.1.3 was created

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment (only update.ps1 is affected here, so install/uninstall has not been checked).
  • The changes only affect a single package (not including meta package).

This commit updates the automatic updater to make use of our
new helper for GitHub when acquiring GitHub releases.
This makes the automatic updater work again, as the old method had
stopped worked a while back.

fixes chocolatey-community#2194
This will allows us to push out fix versions if we have a need to do so
in the future.
@AdmiringWorm AdmiringWorm self-assigned this Mar 27, 2023
@AdmiringWorm AdmiringWorm requested review from a team and JPRuskin and removed request for a team March 27, 2023 15:03
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Copy link
Contributor

@JPRuskin JPRuskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JPRuskin JPRuskin merged commit 5b20cbb into chocolatey-community:master Mar 27, 2023
@AdmiringWorm AdmiringWorm deleted the librecad-fix branch March 27, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(librecad) Package is failing automated updater
3 participants