Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing metrics label values in lower case only #49

Open
pradeepcdlm opened this issue Sep 12, 2018 · 4 comments
Open

Showing metrics label values in lower case only #49

pradeepcdlm opened this issue Sep 12, 2018 · 4 comments

Comments

@pradeepcdlm
Copy link

Thank you for this work!

Currently, Prometheus-SQL returns all metrics label values in lower case only. It'd be great if Prometheus-SQL returns the metrics value without converting to lower case.

Regards,

@bruth
Copy link
Contributor

bruth commented Sep 12, 2018

Appears to be two locations this is done: https://github.com/chop-dbhi/prometheus-sql/search?q=ToLower&unscoped_q=ToLower. The latter is a check to determine if its a facet or not, the former seems to be the root issue.

@pradeepcdlm
Copy link
Author

Thanks, Bruth for this update,

Shall I work on this repo to make configuration settings in the YML file to check to see whether a case conversion can be implemented by conditionally applying the method ToLower()?
And also if we get back to you with this change, can you accept our pull request to integrate it into your repo.

Regards,

@bruth
Copy link
Contributor

bruth commented Sep 12, 2018

Yes please do. I think a config flag for this major cycle is the safest to not break anything. For your use case you can "turn it on".

I will certainly review the PR and provide feedback with every intention to merge it.

@pschou
Copy link

pschou commented Nov 1, 2020

I've added this feature in pull request #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants