Manage puppet agent config from a central mcollective client #54
Conversation
…r the puppet agent.
|
Thank you, this is interesting. We'll need to review it still but can you please open a ticket @ http://projects.puppetlabs.com/projects/mcollective-plugins/issues so we can track it there. Immediately I'd say before we can merge it the DDL needs to be improved with actual inputs and outputs listed and we'd need to see some tests written Alternatively you can host it as is in your github and we can add a link to it from the plugins wiki page. thanks! |
|
Hi, Can you point me to an example test or some docyumentation? I wrote this by looking at puppetd and do not really follow the entire framework. Also what needs to be added to the DDL specifically? I definitely don't mind updating it. Thanks, Alex |
|
See these for examples of tests https://github.com/puppetlabs/mcollective-plugins/tree/master/agent/service/spec you need the mcollective-test gem to run them And see http://docs.puppetlabs.com/mcollective/reference/plugins/ddl.html about the DDL - basically every request input and reply output has to appear there for every action with validation to prevent input based attacks etc |
|
@ripienaar I will add the tests as well and open the ticket. I have updated the ddl. Can you take a peak and let me know if I am on the right track. Thanks. |
|
yeah DDL looking good :) |
|
@ripienaar I added a ticket : |
|
@ripienaar Are there any docs on the rspec tests? I am having some dependency issue (probably because I do no know how to run them). |
|
CLA Signed by lindenle on 2012-04-11 21:00:00 -0700 |
The new plugin allows you to change environment or server in the agent config. In our case this is often needed because environments disapear as they are promoted to the next stage in our workflow. We automatically switch the environments on nodes over to the production environment using mcollective to prevent dangling nodes.