Add some config to custom SMTP server #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-mckay
reviewed
Dec 2, 2024
| @@ -310,7 +310,7 @@ def email_addr_placeholder(username): | |||
| username: str | |||
| The username of the user. | |||
| """ | |||
| return ("{}@" + cfg.email.email_domain).format(username) | |||
| return ("v.{}@" + cfg.email.email_domain).format(username) | |||
There was a problem hiding this comment.
This file is really a template, so site specific changes should not be included.
jay-mckay
reviewed
Dec 2, 2024
etc/config.toml
Outdated
Comment on lines
24
to
25
| smtp_passwd = '' # Used to login | ||
| smtp_starttls = true # default false |
There was a problem hiding this comment.
I believe most users do not use this, so it will probably be best to have these commented out in the example configuration file, along with a comment adding more information as to why it is used.
There was a problem hiding this comment.
Thanks for your reply. In my case, I must use SMTP login and enable STARTTLS to send emails to the email server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two SMTP parameters to enable login for mail servers, including the starttls parameter and a login requirement.