Skip to content

Commit

Permalink
android build: Update jsBundleDirRelease for AGP 7.1+, fixing crash o…
Browse files Browse the repository at this point in the history
…n startup

This is a new incarnation of the same underlying React Native
issue seen in 8f8a266 and 833d083, back in 2019 and 2018
respectively.  RN hard-codes what intermediate directory it
expects the Android Gradle Plugin to look for assets in; but that
directory isn't any kind of stable API, and in fact it changes
from time to time in new versions of AGP.  It changed again
in AGP 7.1.0.

More recent versions of RN know about this latest change (with yet
another hardcoding, conditioned on a new range of AGP versions):
  facebook/react-native#33057
But ours doesn't, because we haven't been updating RN for a while in
this legacy codebase.  So just update the directory we force it to.

See discussion:
  https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/release.20build.20missing.20JS.20bundle/near/1746718

[greg: expanded commit message]
  • Loading branch information
chrisbobbe authored and gnprice committed Feb 27, 2024
1 parent 25b2bd6 commit eb56300
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ apply plugin: "kotlin-android-extensions"
project.ext.react = [
enableHermes : false, // clean and rebuild if changing
// quasi-unstable: see commits 8f8a266af and 833d083a9
jsBundleDirRelease: "$buildDir/intermediates/merged_assets/release/out"
jsBundleDirRelease: "$buildDir/intermediates/assets/release/mergeReleaseAssets"
]

apply from: "../../node_modules/react-native/react.gradle"
Expand Down

0 comments on commit eb56300

Please sign in to comment.