Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test add/list rpc #47

Merged
merged 16 commits into from
Jan 2, 2024
Merged

Test add/list rpc #47

merged 16 commits into from
Jan 2, 2024

Conversation

fmhoeger
Copy link
Collaborator

@fmhoeger fmhoeger commented Dec 19, 2023

Add test for smaug wallet RPC add/list

Depends on #45 being merged first

Needs commit history cleanup or squash merging

@fmhoeger fmhoeger self-assigned this Dec 19, 2023
@fmhoeger fmhoeger marked this pull request as ready for review December 25, 2023 20:46
@fmhoeger
Copy link
Collaborator Author

Also added a test for the add RPC as there is some overlap/redundancy with respect to the list RPC.

@fmhoeger fmhoeger linked an issue Dec 26, 2023 that may be closed by this pull request
@fmhoeger fmhoeger changed the title 46 test list rpc Test list rpc Dec 26, 2023
@fmhoeger fmhoeger changed the title Test list rpc Test add/list rpc Dec 26, 2023
Copy link
Owner

@chrisguida chrisguida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisguida chrisguida merged commit 8ce03ac into feat/add-tests Jan 2, 2024
1 check passed
@chrisguida chrisguida mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test list rpc
2 participants