-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adventure mode actor collisions (update of #1037) #1232
Open
jessemillar
wants to merge
26
commits into
chrismaltby:develop
Choose a base branch
from
jessemillar:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Adventure mode does not support solid collision between actors and the player.
Actors have a 'solid' property. When it is enabled, the player will collide with other actors like a wall. Diagonal movement allows the player to slide along the edge of solid actors (even when the solid actor is moving).
No breaking changes.
This PR is a modification of #1037. I solved the merge conflicts, implemented @chrismaltby's suggestion of increasing a check to
+ 3
and> 6
, and fixed the bug reported insolid_bug2.mp4
.I did not tackle the Platforming bug report from
solid_bug.mp4
in my PR because I haven't build a platforming game yet and currently have no need for the enhancements.As an aside, when copying and pasting an actor with the new, solid direction checkboxes ("Top", "Bottom", etc.), the checkbox values are not properly copied after pasting. I perused the paste helpers and middleware but could not figure out how to add support. I'd be happy to if someone more knowledgeable could give me a tip.
This is a test GB Studio project that I used to verify functionality.
collision-tests-clean-merge.zip