Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adventure mode actor collisions (update of #1037) #1232

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

jessemillar
Copy link

@jessemillar jessemillar commented Oct 25, 2022

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

Adventure mode does not support solid collision between actors and the player.

  • What is the new behavior (if this is a feature change)?

Actors have a 'solid' property. When it is enabled, the player will collide with other actors like a wall. Diagonal movement allows the player to slide along the edge of solid actors (even when the solid actor is moving).
image

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No breaking changes.

  • Other information:

This PR is a modification of #1037. I solved the merge conflicts, implemented @chrismaltby's suggestion of increasing a check to + 3 and > 6, and fixed the bug reported in solid_bug2.mp4.

I did not tackle the Platforming bug report from solid_bug.mp4 in my PR because I haven't build a platforming game yet and currently have no need for the enhancements.

As an aside, when copying and pasting an actor with the new, solid direction checkboxes ("Top", "Bottom", etc.), the checkbox values are not properly copied after pasting. I perused the paste helpers and middleware but could not figure out how to add support. I'd be happy to if someone more knowledgeable could give me a tip.

This is a test GB Studio project that I used to verify functionality.
collision-tests-clean-merge.zip

um3k and others added 25 commits January 28, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants