Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for python #17

Merged
merged 1 commit into from
Aug 19, 2024
Merged

add support for python #17

merged 1 commit into from
Aug 19, 2024

Conversation

DerMolly
Copy link
Contributor

@DerMolly DerMolly commented Aug 17, 2024 •
edited
Loading

TIC-80 supports python since May 2023 or so. nesbox/TIC-80#2184

chronoDave
chronoDave reviewed Aug 18, 2024
View reviewed changes
Copy link
Owner

@chronoDave chronoDave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changes in utils.js, getCommentStyle should have a Python check as well.

@DerMolly
Copy link
Contributor Author

I'm unsure what you mean. I changed getCommentStyle in utils.js or do you mean I should add tests? If you mean the later could you point me to where you want those test, because I find no test that directly test getCommentStyle and I thought I changed the relevant test already.

@chronoDave
Copy link
Owner

Apologies, you're right. Looks good to me

@chronoDave chronoDave merged commit 7373443 into chronoDave:master Aug 19, 2024
1 check failed
@DerMolly DerMolly deleted the python_support branch August 19, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronoDave chronoDave chronoDave left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerMolly @chronoDave