Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional metadata #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DerMolly
Copy link
Contributor

There are some more metadata tags as mentioned in #11. I added the ones that are there by default if you create a new game in tic-80, but we should probably include menu and strict as well at some point…

@chronoDave
Copy link
Owner

Thanks for opening the PR, as mentioned in #11, would you happen to have a source for these metadata changes?

@DerMolly
Copy link
Contributor Author

As mentioned they are present, when you create a new game in a current version of TIC-80. Not sure if it's explained elsewhere. The documentation that is linked README.md was not updated, which it probably should be.

@chronoDave
Copy link
Owner

chronoDave commented Aug 19, 2024

If you could update the link to point to https://github.com/nesbox/TIC-80/wiki/Cartridge-Metadata instead, that'd be great.

Looking through that wiki page and scouring through TIC-80's repo, I struggle to find how and where these metadata values are used. The most recent demo seems to be janetdemo.janet which does include site and license as you've added, but also a missing field strict.

Given the lack of documentation, would you say it would be better for tic-bundle to support additional custom tags?

{
  metadata: {
    ...
    mycustomtag: 'mycustomvalue'
  }
}
--mycustomtag: mycustomvalue

@DerMolly
Copy link
Contributor Author

I think that would be a good solution to the problem at hand. Question is should this be in addition to this PR? Or instead of? What do you think?

@chronoDave
Copy link
Owner

Can be a separate PR as it falls outside the scope of this PR. I've created an issue for it: #19

Given that the tags you've added are available in TIC-80 demo files I'm alright with merging them. Only request I have is removing the default value for license as mentioned prior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants