Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option on job to specify waitRetryDelay and bumped API version … #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tbfangel
Copy link

@tbfangel tbfangel commented May 2, 2016

…to 1.22

@chrylis
Copy link
Owner

chrylis commented May 5, 2016

This looks potentially useful. Are there any changes to the postback format in 1.22 that could potentially cause trouble?

The chained constructor looks fine, but please remove the whitespace commit noise; in particular, the blank lines around the assignments are there intentionally to group the constraint checks with their values.

Note that as of Java 8, all of the Javadocs need to be filled out (e.g., no blank @return) or Bad Things can happen.

@tbfangel
Copy link
Author

tbfangel commented May 8, 2016

OK, I'll commit the changes as you suggest one of the next days.

Concerning the API version, I have not noticed anything that could potentially cause trouble. We have been running with API level 1.22 for some time now and haven't had any issues so far (but we're also only using a very small subset of the functionality).

BTW, I actually have a somewhat bigger change that adds long polling to the library. Since our service is in a private network, we cannot rely on post backs, so I have added a long poll request. Would you be interested in me adding this in a different PR?

@tbfangel
Copy link
Author

Any progress on merging this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants