Fix ChunkDataVersion issues with third party applications #1466
Conversation
NotStirred
force-pushed
the
feature/force_genericchunkdata
branch
from
125e095 to
9f8d3a0
Compare
NotStirred
changed the title
leMaik
added
bug
minecraft
| @@ -168,7 +169,8 @@ public synchronized boolean loadChunk(@NotNull Mutable<ChunkData> chunkData, int | |||
|
|
|||
| surfaceTimestamp = dataTimestamp; | |||
| version = chunkVersion(data); | |||
| chunkData.set(this.world.createChunkData(chunkData.get(), data.get(DATAVERSION).intValue())); | |||
| IntIntImmutablePair chunkBounds = inclusiveChunkBounds(data); | |||
| chunkData.set(this.world.createChunkData(chunkData.get(), chunkBounds.leftInt(), chunkBounds.rightInt())); | |||
There was a problem hiding this comment.
Could we use yMin and yMax instead of parsing the chunk bounds on every chunk? Although we would probably need to test to see which one is faster.
|
This PR is somewhat difficult to test. We still have #1175 which may or may not be related which could be causing issues. There are certain moments when I can sometimes load 1 chunk or 20k chunks to the correct 0 to 320 height. Other times I can do 0 to 256. Retyping the Retyping the The Loading 10k chunks Map view (max Map Y clip 320) gives an indication as to where terrain should be Map view with max Map Y clip at 256 shows that terrain in the preview is still cut at 256. Loading just 1024 chunks |
|
The screenshots in the previous comment worried me so I didn't merge this PR yet. Are these issues caused by this PR or could this be merged? If this PR is fine, could you please rebase it, @NotStirred? 🙏 |
NotStirred
force-pushed
the
feature/force_genericchunkdata
branch
from
9f8d3a0 to
69d167d
Compare
… version. This fixes annoying ChunkDataVersion issues with third-party apps like WorldPainter
leMaik
force-pushed
the
feature/force_genericchunkdata
branch
from
69d167d to
611bd42
Compare
Some WorldPainter worlds have their ChunkDataVersion set to a version prior to minecraft's support for worlds with >=256 height.
This PR changes how we create
ChunkDataobjects to be based on the actual block range found in a chunk, rather than its version