Use a ChoiceBox for water shader #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leMaik
reviewed
Sep 26, 2023
chunky/src/java/se/llbit/chunky/renderer/WaterShadingStrategy.java
Outdated
Show resolved
Hide resolved
leMaik
approved these changes
Oct 27, 2023
|
The changes look good to me. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
Still waterandProcedural watercheckboxes and replaced them with aWater shaderdropdown that contins options:SIMPLEX(default),LEGACY, andSTILL. Also updated the persistent settings to support the new GUI. Scenes from older versions should have their water settings preserved when loaded.New:
