Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use y-clipping settings from the map view when creating a new scene or loading chunks from it #1770

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

leMaik
Copy link
Member

@leMaik leMaik commented Sep 23, 2024

Also fixes requiring two reloads after changing the y-clipping settings of a scene.

Closes #1741

…r loading chunks from it and fix requiring two reloads after changing the y-clipping settings of a scene.
@leMaik leMaik requested a review from Peregrine05 September 24, 2024 12:19
Copy link
Member

@Peregrine05 Peregrine05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things seem slightly confusing now.

Chunky appears to use the Map Y clip when Load selected chunks or New scene from selection in the Map tab context menu is used, but it uses the Scene Y clip when Load selected chunks or Reload chunks in the Scene tab is used. Additionally, changing the Map Y clip while the Scene tab is open causes the Scene Y clip values to apparently reset to their default values; however, the internal values are not changed, and the UI values are set properly once it refreshes.

I think that either there should be one set of sliders that controls both the map view and the scene clip, or there should be two separate sets of sliders, as Chunky was previously, but with a note that points users to the Scene tab to change the Scene Y clip.

As I recall, the main issue was that the Scene Y clip values were not being set properly, which resulted in portions of the world not being loaded. Users would see the Map Y clip controls, and assume that they changed the Scene Y clip, so a note next to them, I believe, would be effective.

@leMaik
Copy link
Member Author

leMaik commented Sep 24, 2024

Chunky appears to use the Map Y clip when Load selected chunks or New scene from selection in the Map tab context menu is used, but it uses the Scene Y clip when Load selected chunks or Reload chunks in the Scene tab is used.

@Peregrine05 This is exactly the intended behavior. I do see that it might be confusing if you create a scene from the left panel – I didn't consider that.

Additionally, changing the Map Y clip while the Scene tab is open causes the Scene Y clip values to apparently reset to their default values; however, the internal values are not changed, and the UI values are set properly once it refreshes.

That is not supposed to happen… I'll look into this. The scene tab is supposed to represent the scene state, regardless of whatever the map view does.

Users would see the Map Y clip controls, and assume that they changed the Scene Y clip, so a note next to them, I believe, would be effective.

Users would expect that the y clip controls from the map are applied when creating a new scene – which is what this PR does. After a scene has been created, the y clip (as well as any other scene settings) can be controlled in the scene tab.

two separate sets of sliders, as Chunky was previously, but with a note that points users to the Scene tab to change the Scene Y clip.

A UI that needs a note to explain how it works is the worst solution we could find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix y clipping defaults
2 participants