Update eslint-plugin-ember to 12.0.0 (#1651)

* Update eslint-plugin-ember to 12.0.0 * Fix ember/no-empty-glimmer-component-classes
cibernox · Jan 18, 2024 · 94cd842 · 94cd842
1 parent 41ca769
commit 94cd842
Show file tree

Hide file tree

Showing 12 changed files with 136 additions and 83 deletions.
diff --git a/docs/.eslintrc.js b/docs/.eslintrc.js
@@ -15,7 +15,9 @@ module.exports = {
   env: {
     browser: true,
   },
-  rules: {},
+  rules: {
+    'ember/no-runloop': 0,
+  },
   overrides: [
     // ts files
     {

diff --git a/docs/package.json b/docs/package.json
@@ -97,7 +97,7 @@
     "ember-try": "^3.0.0",
     "eslint": "^8.56.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-ember": "^11.11.1",
+    "eslint-plugin-ember": "^12.0.0",
     "eslint-plugin-n": "^16.6.2",
     "eslint-plugin-prettier": "^5.1.3",
     "eslint-plugin-qunit": "^8.0.1",

diff --git a/ember-power-select/.eslintrc.cjs b/ember-power-select/.eslintrc.cjs
@@ -15,7 +15,9 @@ module.exports = {
   env: {
     browser: true,
   },
-  rules: {},
+  rules: {
+    'ember/no-runloop': 0,
+  },
   overrides: [
     // ts files
     {

diff --git a/ember-power-select/package.json b/ember-power-select/package.json
@@ -124,7 +124,7 @@
     "ember-template-lint": "^5.13.0",
     "eslint": "^8.56.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-ember": "^11.11.1",
+    "eslint-plugin-ember": "^12.0.0",
     "eslint-plugin-n": "^16.6.2",
     "eslint-plugin-prettier": "^5.1.3",
     "node-sass": "^9.0.0",

diff --git a/ember-power-select/src/components/power-select/no-matches-message.ts b/ember-power-select/src/components/power-select/no-matches-message.ts
@@ -1,4 +1,4 @@
-import Component from '@glimmer/component';
+import templateOnly from '@ember/component/template-only';
 
 interface PowerSelectNoMatchesMessageSignature {
   Element: HTMLElement;
@@ -7,4 +7,4 @@ interface PowerSelectNoMatchesMessageSignature {
   };
 }
 
-export default class PowerSelectNoMatchesMessageComponent extends Component<PowerSelectNoMatchesMessageSignature> {}
+export default templateOnly<PowerSelectNoMatchesMessageSignature>();
diff --git a/ember-power-select/src/components/power-select/placeholder.ts b/ember-power-select/src/components/power-select/placeholder.ts
@@ -1,4 +1,4 @@
-import Component from '@glimmer/component';
+import templateOnly from '@ember/component/template-only';
 
 interface PowerSelectPlaceholderSignature {
   Element: HTMLElement;
@@ -9,4 +9,4 @@ interface PowerSelectPlaceholderSignature {
   };
 }
 
-export default class PowerSelectPlaceholderComponent extends Component<PowerSelectPlaceholderSignature> {}
+export default templateOnly<PowerSelectPlaceholderSignature>();
diff --git a/ember-power-select/src/components/power-select/power-select-group.ts b/ember-power-select/src/components/power-select/power-select-group.ts
@@ -1,4 +1,4 @@
-import Component from '@glimmer/component';
+import templateOnly from '@ember/component/template-only';
 
 interface PowerSelectPowerSelectGroupSignature {
   Element: HTMLElement;
@@ -10,4 +10,4 @@ interface PowerSelectPowerSelectGroupSignature {
   };
 }
 
-export default class PowerSelectPowerSelectGroupComponent extends Component<PowerSelectPowerSelectGroupSignature> {}
+export default templateOnly<PowerSelectPowerSelectGroupSignature>();
diff --git a/ember-power-select/src/components/power-select/search-message.ts b/ember-power-select/src/components/power-select/search-message.ts
@@ -1,4 +1,4 @@
-import Component from '@glimmer/component';
+import templateOnly from '@ember/component/template-only';
 
 interface PowerSelectSearchMessageSignature {
   Element: HTMLElement;
@@ -7,4 +7,4 @@ interface PowerSelectSearchMessageSignature {
   };
 }
 
-export default class PowerSelectSearchMessageComponent extends Component<PowerSelectSearchMessageSignature> {}
+export default templateOnly<PowerSelectSearchMessageSignature>();
diff --git a/package.json b/package.json
@@ -20,10 +20,10 @@
     "start:test-app": "pnpm run --filter test-app start"
   },
   "devDependencies": {
-    "@release-it-plugins/lerna-changelog": "^6.0.0",
-    "@release-it-plugins/workspaces": "^4.0.0",
-    "concurrently": "^8.2.0",
-    "prettier": "^3.0.3",
+    "@release-it-plugins/lerna-changelog": "^6.1.0",
+    "@release-it-plugins/workspaces": "^4.2.0",
+    "concurrently": "^8.2.2",
+    "prettier": "^3.2.4",
     "prettier-plugin-ember-template-tag": "^2.0.0",
     "release-it": "^17.0.1"
   },