Set args.options as optional
#1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To me, all cases of undefined args.options seems to handled well, so undefined options should not give a glint type error.
|
@johanrd yes its correct... i'm not sure, but i think we can also set If you want, you can set also |
|
@mkszepp yes, good point. undefined args.selected seems to be handled well as well |
johanrd
added a commit
to johanrd/ember-power-select
that referenced
this pull request
Jan 17, 2024
See cibernox#1649. All cases of undefined seems to be handled well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To me, all cases of undefined args.options seems to handled well, so undefined options should not give a glint type error.