Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect Element from args in PowerSelectMultipleTrigger #1862

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Nov 19, 2024

Discovered in one of my glint projects that we have in multiple trigger the parameter Element.

This brings some issues.

  1. The paramter is required and you need to pass a HTMLElement which is unused
  2. you need to add template-lint-disable no-capital-arguments, because parameters in uppercase are not allowed

This bug was maybe introduced when there was added glint inside power select

We can safely remove this parameter

@mkszepp mkszepp added the bug label Nov 19, 2024
@mkszepp mkszepp changed the title Remove Element from args in PowerSelectMultipleTrigger Remove incorrect Element from args in PowerSelectMultipleTrigger Nov 19, 2024
@mkszepp mkszepp merged commit d5e014f into master Nov 19, 2024
20 checks passed
@mkszepp mkszepp deleted the fix-incorrect-element-arg branch November 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant