-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFP: Clang format for BPF formatting #41
base: main
Are you sure you want to change the base?
Conversation
92ea98a
to
a192f38
Compare
Discussed in a 1:1:
|
a192f38
to
65f4efa
Compare
@dylandreimerink we now have statuses for CFPs https://github.com/cilium/design-cfps#status. Please add the one that you think fits here |
For context, I think this core idea was provided ample opportunity for input (for instance through sharing in Slack and community weekly meetings). The new status process only expects that prior to merge one committer approves the design that it is implementable and doesn't have major flaws / contention points. Both of you are committers so if you two agree then I would suggest marking it as "Implementable". Once implementable it can be merged, even if you still wish to iterate a bit further on the design points - those additions can come as subsequent PRs modifying this file. |
Signed-off-by: Dylan Reimerink <[email protected]>
65f4efa
to
0a0f1d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this. Do we have two volunteers to populate the committee?
This CFP proposes to start using clang-format to format the Cilium C code, and a process for introducing it and resolving changes in formatting.