Fix image builds and extend CI coverage to build images on PRs #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
force-pushed
the
pr/tklauser/tester-fix-build
branch
from
92012c5 to
84ca9f1
Compare
A recent dependency update broke the build of the tester image [1]. This was only caught on master because that image is not built in CI on PRs. A successive commit will fix that. [1] https://github.com/cilium/image-tools/actions/runs/8371783081/job/22921438140 Fixes: e9b6594 ("build(deps): bump github.com/docker/docker in /images/tester/cst") Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
pr/tklauser/tester-fix-build
branch
2 times, most recently
from
0c60f70 to
bb41ce6
Compare
tklauser
changed the title
Ubuntu 22.04 LTS updated GCC 9 to 9.5.0, adjust the version in the spec. Also, we started building multiarch images and the arm64 cross-compile packages aren't available when building the linux/arm64 image, so skip the installation. Signed-off-by: Tobias Klauser <[email protected]>
Currently images are only built (and pushed) on pushes to the master branch, i.e. once the PR is merged. This can lead to situations where the image build is broken by a PR but the breakage is only caught later on, see e.g. [1] and [2]. Fix this by also building the images on PRs but only push them to the registry for master pushes as previously. [1] #233 (comment) [2] #240 Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
pr/tklauser/tester-fix-build
branch
from
bb41ce6 to
01cbb4c
Compare
christarazi
approved these changes
Mar 21, 2024
aanm
approved these changes
Mar 22, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the image build on
masterafter a recent dependency update broke it. Also extend CI to build all images so breakages should be caught in CI on PRs already.See commits for details.