rubocop

* Capybara/ClickLinkOrButtonStyle
* Capybara/RSpec/HaveSelector
* Rails/RedundantActiveRecordAllMethod
* RSpec/Rails/HaveHttpStatus
* RSpec/Rails/HttpStatus
* RSpec/Rails/InferredSpecType
* Style/RedundantConstantBase

app/controllers/admin/past_events_controller.rb

@@ -3,7 +3,7 @@ class PastEventsController < AdminController
     before_action :past_event, only: %i[destroy edit show update]
 
     def index
-      @past_events = PastEvent.all.order('date DESC')
+      @past_events = PastEvent.order('date DESC')
     end
 
     def show; end

app/controllers/admin/speakers_controller.rb

@@ -3,7 +3,7 @@ class SpeakersController < AdminController
     before_action :speaker, only: %i[destroy edit show update]
 
     def index
-      @speakers = Speaker.all.order('name')
+      @speakers = Speaker.order('name')
     end
 
     def show; end

config/environments/production.rb

@@ -76,7 +76,7 @@
   config.active_support.report_deprecations = false
 
   # Use default logging formatter so that PID and timestamp are not suppressed.
-  config.log_formatter = ::Logger::Formatter.new
+  config.log_formatter = Logger::Formatter.new
 
   # Use a different logger for distributed setups.
   # require "syslog/logger"

config/environments/staging.rb

@@ -75,7 +75,7 @@
   config.active_support.deprecation = :notify
 
   # Use default logging formatter so that PID and timestamp are not suppressed.
-  config.log_formatter = ::Logger::Formatter.new
+  config.log_formatter = Logger::Formatter.new
 
   # Use a different logger for distributed setups.
   # require 'syslog/logger'

lib/tasks/cucumber.rake

@@ -39,8 +39,8 @@ unless ARGV.any? { |a| a =~ /^gems/ } # Don't load anything when running the gem
 
       task statsetup: :environment do
         require 'rails/code_statistics'
-        ::STATS_DIRECTORIES << ['Cucumber features', 'features'] if File.exist?('features')
-        ::CodeStatistics::TEST_TYPES << "Cucumber features" if File.exist?('features')
+        STATS_DIRECTORIES << ['Cucumber features', 'features'] if File.exist?('features')
+        CodeStatistics::TEST_TYPES << "Cucumber features" if File.exist?('features')
       end
     end
     desc 'Alias for cucumber:ok'

spec/models/meeting_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe Meeting, type: :model do
+RSpec.describe Meeting do
   describe ".next_meeting" do
     before { allow(described_class).to receive(:ruby_brigade_meetings).and_return([1, 2, 3, 4]) }
 

spec/models/past_event_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe PastEvent, type: :model do
+RSpec.describe PastEvent do
   context 'Associations & Validations' do # rubocop:disable RSpec/ContextWording
     before { build(:past_event) }
 

spec/models/speaker_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe Speaker, type: :model do
+RSpec.describe Speaker do
   context 'Associations & Validations' do # rubocop:disable RSpec/ContextWording
     before { build(:speaker) }
 

spec/models/video_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe Video, type: :model do
+RSpec.describe Video do
   context 'Associations & Validations' do # rubocop:disable RSpec/ContextWording
     before { build(:video) }
 

spec/requests/admin/past_events_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe '/admin/past_events', type: :request do
+RSpec.describe '/admin/past_events' do
   let!(:admin_user) { create(:admin_user, password: 'P4ssw0rd!') }
   let!(:speaker) { create(:speaker) }
   let(:valid_attributes) {

spec/requests/admin/speakers_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe '/admin/speakers', type: :request do
+RSpec.describe '/admin/speakers' do
   let!(:admin_user) { create(:admin_user, password: 'P4ssw0rd!') }
   let!(:speaker) { create(:speaker) }
   let(:valid_attributes) { { name: Faker::Name.unique.name } }

spec/requests/admin/videos_spec.rb

@@ -2,7 +2,7 @@
 require 'securerandom'
 
 module Admin
-  RSpec.describe VideosController, type: :request do
+  RSpec.describe VideosController do
     let!(:admin_user) { create(:admin_user, password: 'P4ssw0rd!') }
     let!(:video) { create(:video) }
     let(:valid_attributes) { { past_event_id: video.past_event.id, url: Faker::Internet.url(host: 'example.com', path: "/videos/#{SecureRandom.alphanumeric(8)}") } }

spec/requests/application_controller_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe ApplicationController, type: :request do
+RSpec.describe ApplicationController do
   describe 'logging in' do
     let(:admin_user) { create(:admin_user, password:) }
     let(:email) { admin_user.email }

spec/requests/pages_controller_spec.rb

@@ -4,15 +4,15 @@
   describe 'GET #index' do
     it 'is publicly accessible' do
       VCR.use_cassette('pages_controller_spec-get-index', record: :new_episodes) { get :index, params: {} }
-      expect(response.code).to eq('200')
+      expect(response).to have_http_status(:ok)
     end
   end
 
   describe 'GET #this_month_in_ruby' do
     it 'is publicly accessible' do
       get :this_month_in_ruby
 
-      expect(response.code).to eq('200')
+      expect(response).to have_http_status(:ok)
     end
   end
 end

spec/requests/past_events_controller_spec.rb

@@ -4,15 +4,15 @@
   describe 'GET #index' do
     it 'is publicly accessible' do
       VCR.use_cassette('past_events_controller_spec-get-index', record: :new_episodes) { get :index, params: {} }
-      expect(response.code).to eq('200')
+      expect(response).to have_http_status(:ok)
     end
   end
 
   describe 'GET #show' do
     it 'is publicly accessible' do
       get :show, params: { year: '2005', month: '2' }
 
-      expect(response.code).to eq('200')
+      expect(response).to have_http_status(:ok)
     end
   end
 end

spec/routing/admin/past_events_routing_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe Admin::PastEventsController, type: :routing do
+RSpec.describe Admin::PastEventsController do
   describe "routing" do
     it "routes to #create" do
       expect(post: "/admin/past_events").to route_to("admin/past_events#create")

spec/routing/admin/speakers_routing_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe Admin::SpeakersController, type: :routing do
+RSpec.describe Admin::SpeakersController do
   describe "routing" do
     it "routes to #create" do
       expect(post: "/admin/speakers").to route_to("admin/speakers#create")

spec/routing/admin/videos_routing_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe Admin::VideosController, type: :routing do
+RSpec.describe Admin::VideosController do
   describe "routing" do
     it "routes to #create" do
       expect(post: "/admin/videos").to route_to("admin/videos#create")

spec/routing/devise_routing_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 module Devise
-  RSpec.describe SessionsController, type: :routing do
+  RSpec.describe SessionsController do
     describe 'routing' do
       it 'routes to #new' do
         expect(get: '/admin/login').to route_to('devise/sessions#new')
@@ -21,7 +21,7 @@ module Devise
     end
   end
 
-  RSpec.describe PasswordsController, type: :routing do
+  RSpec.describe PasswordsController do
     describe 'routing' do
       it 'routes to #create' do
         expect(post: '/admin/password').to route_to('devise/passwords#create')

spec/routing/pages_routing_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe PagesController, type: :routing do
+RSpec.describe PagesController do
   it { is_expected.to route(:get, '/').to(action: :index) }
   it { is_expected.to route(:get, '/this_month_in_ruby').to(action: :this_month_in_ruby) }
 end

spec/routing/past_events_routing_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe PastEventsController, type: :routing do
+RSpec.describe PastEventsController do
   it { is_expected.to route(:get, '/past_events').to(action: :index) }
   it { is_expected.to route(:get, '/past_events/2005/2').to(action: :show, year: '2005', month: '2') }
 end

spec/system/admin/authentication_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe 'Authentication', type: :system do
+RSpec.describe 'Authentication' do
   subject { page }
 
   let(:password) { 'P4ssw0rd' }
@@ -12,7 +12,7 @@
 
       fill_in :admin_user_email, with: admin_user.email
       fill_in :admin_user_password, with: password
-      click_on 'Log in'
+      click_button 'Log in'
     end
 
     it { is_expected.to have_text('Signed in successfully.') }
@@ -24,7 +24,7 @@
 
       fill_in :admin_user_email, with: admin_user.email
       fill_in :admin_user_password, with: "#{password}-fat-fingers!"
-      click_on 'Log in'
+      click_button 'Log in'
     end
 
     it { is_expected.to have_text('Invalid email or password.') }

spec/system/admin/past_events_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "PastEvent Administration", type: :system do
+RSpec.describe "PastEvent Administration" do
   let!(:admin_user) { create(:admin_user, email: '[email protected]', password: 'P4ssw0rd') }
   let!(:other_speaker) { create(:speaker, name: 'Chris Nelson') }
 
@@ -12,7 +12,7 @@
 
       fill_in :admin_user_email, with: admin_user.email
       fill_in :admin_user_password, with: 'P4ssw0rd'
-      click_on 'Log in'
+      click_button 'Log in'
 
       visit new_admin_past_event_path
       expect(page).to have_text('New Past Event')
@@ -25,7 +25,7 @@
       select other_speaker.name, from: 'past_event[speaker_ids][]'
       fill_in 'past_event[description]', with: 'No, we mean it! This is a reeeeally cool Rails feature.'
 
-      click_on 'commit'
+      click_button 'commit'
 
       new_past_event = PastEvent.last
       expect(new_past_event.topic).to eq('A Really Cool Rails Feature')
@@ -41,7 +41,7 @@
 
       fill_in :admin_user_email, with: admin_user.email
       fill_in :admin_user_password, with: 'P4ssw0rd'
-      click_on 'Log in'
+      click_button 'Log in'
 
       visit edit_admin_past_event_path(past_event)
       expect(page).to have_text('Editing Past Event')
@@ -51,7 +51,7 @@
       unselect past_event.speakers.first.name, from: 'past_event[speaker_ids][]'
       select other_speaker.name, from: 'past_event[speaker_ids][]'
 
-      click_on 'commit'
+      click_button 'commit'
 
       expect(past_event.reload.speakers.map(&:name).sort).to eq([other_speaker.name, past_event.speakers.last.name].sort)
     end
@@ -67,7 +67,7 @@
 
       fill_in :admin_user_email, with: admin_user.email
       fill_in :admin_user_password, with: 'P4ssw0rd'
-      click_on 'Log in'
+      click_button 'Log in'
 
       visit admin_past_events_path
       expect(page).to have_text('Past Events')

spec/system/admin/speakers_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "Speaker Administration", type: :system do
+RSpec.describe "Speaker Administration" do
   let!(:admin_user) { create(:admin_user, email: '[email protected]', password: 'P4ssw0rd') }
 
   context 'when creating' do
@@ -10,7 +10,7 @@
       fill_in :admin_user_email, with: admin_user.email
       fill_in :admin_user_password, with: 'P4ssw0rd'
 
-      click_on 'Log in'
+      click_button 'Log in'
 
       visit new_admin_speaker_path
       expect(page).to have_text('New Speaker')
@@ -22,7 +22,7 @@
       fill_in 'speaker[email]', with: '[email protected]'
       fill_in 'speaker[image_url]', with: 'https://example.com/jimweirich/images/avatar.png'
 
-      click_on 'commit'
+      click_button 'commit'
 
       new_speaker = Speaker.last
       expect(new_speaker.name).to eq('Jim Weirich')
@@ -40,7 +40,7 @@
 
       fill_in :admin_user_email, with: admin_user.email
       fill_in :admin_user_password, with: 'P4ssw0rd'
-      click_on 'Log in'
+      click_button 'Log in'
 
       visit edit_admin_speaker_path(speaker)
       expect(page).to have_text('Editing Speaker')
@@ -52,7 +52,7 @@
       fill_in 'speaker[email]', with: "new.#{speaker.email}"
       fill_in 'speaker[image_url]', with: Faker::Internet.url(host: 'example.com', path: '/avatar/new.jpeg')
 
-      click_on 'commit'
+      click_button 'commit'
 
       old_data = speaker.attributes
       speaker.reload
@@ -73,7 +73,7 @@
 
       fill_in :admin_user_email, with: admin_user.email
       fill_in :admin_user_password, with: 'P4ssw0rd'
-      click_on 'Log in'
+      click_button 'Log in'
 
       visit admin_speakers_path
       expect(page).to have_text('Speakers')

spec/system/admin/videos_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 require 'securerandom'
 
-RSpec.describe "Video Administration", type: :system do
+RSpec.describe "Video Administration" do
   let!(:admin_user) { create(:admin_user, email: '[email protected]', password: 'P4ssw0rd') }
   let!(:past_event) { create(:past_event) }
   let(:url) { Faker::Internet.url(host: 'example.com', path: "/videos/#{SecureRandom.alphanumeric(8)}") }
@@ -12,7 +12,7 @@
 
       fill_in :admin_user_email, with: admin_user.email
       fill_in :admin_user_password, with: 'P4ssw0rd'
-      click_on 'Log in'
+      click_button 'Log in'
 
       visit new_admin_video_path
       expect(page).to have_text('New Video')
@@ -22,7 +22,7 @@
       fill_in 'video[url]', with: url
       select past_event.topic, from: 'video[past_event_id]'
 
-      click_on 'commit'
+      click_button 'commit'
 
       new_video = Video.last
       expect(new_video.url).to eq(url)
@@ -39,7 +39,7 @@
 
       fill_in :admin_user_email, with: admin_user.email
       fill_in :admin_user_password, with: 'P4ssw0rd'
-      click_on 'Log in'
+      click_button 'Log in'
 
       visit edit_admin_video_path(video)
       expect(page).to have_text('Editing Video')
@@ -49,7 +49,7 @@
       fill_in 'video[url]', with: "#{video.url}v2"
       select other_event.topic, from: 'video[past_event_id]'
 
-      click_on 'commit'
+      click_button 'commit'
 
       old_data = video.attributes
       video.reload
@@ -68,7 +68,7 @@
 
       fill_in :admin_user_email, with: admin_user.email
       fill_in :admin_user_password, with: 'P4ssw0rd'
-      click_on 'Log in'
+      click_button 'Log in'
 
       visit admin_videos_path
       expect(page).to have_text('Videos')