Merge branch 'main' into 240-add_lineage

cioos-siooc · Oct 31, 2023 · 199e86c · 199e86c
2 parents 3d72a5d + 5434e2b
commit 199e86c
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 8 deletions.
diff --git a/firebase-functions/functions/dataset-name.md b/firebase-functions/functions/dataset-name.md
@@ -15,12 +15,18 @@
 - [ ] Does not include acronyms – put these in the keywords
 - [ ] Does not include the word “dataset”
 - [ ] Time series datasets should include “time series” at the end of the title
-- [ ] Does not include the time period (this is covered in the temporal extents fields)
 
 #### Abstract
 
 - [ ] Abbreviations have been expanded upon at first mention
-- [ ] Abstract describes how, when, what, where, why of data collection and is limited to ~ 250 words
+- [ ] Abstract describes how, when, what, where, why of data collection and is limited to no more than 500 words
+
+#### DOI
+
+- [ ] A DOI has been drafted for this record
+- [ ] DOI has been updated via the form after review and changes to record
+- [ ] DOI has been manually edited on datacite fabrica
+- [ ] DOI status has been changed from Draft to Findable
 
 ### Spatial
 
@@ -30,7 +36,7 @@
 
 - [ ] ROR and ORCID(s) are included and linked properly where applicable
 - [ ] For datasets where DFO is a partner, ensure 'parent' ROR is added (https://ror.org/02qa1x782). DFO 'child' organizations (i.e. CHS) and their ROR are optional.
-- [ ] Include Hakai Institute as Publisher, Distributor, and Owner (if applicable) and include [email protected] as email
+- [ ] Include Hakai Institute as Publisher and include [email protected] as email
 - [ ] Make sure email address is provided if the role is 'Metadata Custodian' or 'Point of Contact' 
 - [ ] Add contact affiliation where known including ROR
 - [ ] Use institutional email adresses where possible for contacts

diff --git a/firebase-functions/functions/issue.js b/firebase-functions/functions/issue.js
@@ -20,7 +20,7 @@ async function createIssue(title, url) {
     owner: "HakaiInstitute",
     repo: "metadata-review",
     title: `Dataset - ${title}`,
-    body: `## ${title}\n\n${url}\n\n${issueText}`,
+    body: `## ${title}\n\n<${url}>\n\n${issueText}`,
   };
 
   await octokit.request("POST /repos/{owner}/{repo}/issues", input);

diff --git a/src/utils/emlTemplate.j2 b/src/utils/emlTemplate.j2
@@ -31,7 +31,7 @@
             <onlineUrl>{{ contact.orgURL }}</onlineUrl>
             <!-- <role> is used by associatedParty, but its a single item not a list -->
             <!-- <role></role> -->
-            <userId directory="http://orcid.org/">{{ contact.indOrcid }}</userId>
+            <userId directory="https://orcid.org/"  >{{ contact.indOrcid }}</userId>
             <!-- NOTE that we can have multiple roles per contact, just get the first -->
         </{{role}} >
         {% endif %}
@@ -57,8 +57,8 @@
         <intellectualRights>
             <para>
                 This work is licensed under
-                <ulink url="{{ record.license.url }}">
-                    <citetitle>{{ record.license.title }}</citetitle>
+                <ulink url="{{ licenses[record.license]?.url }}">
+                    <citetitle>{{ licenses[record.license]?.title }}</citetitle>
                 </ulink>
                 .
             </para>
@@ -77,8 +77,26 @@
                     <southBoundingCoordinate>{{ record.map.south }}</southBoundingCoordinate>
                 </boundingCoordinates>
             </geographicCoverage>
+            <temporalCoverage>
+                <rangeOfDates>
+                    <beginDate>
+                        <calendarDate>{{ record.dateStart }}</calendarDate>
+                    </beginDate>
+                    <endDate>
+                        <calendarDate>{{ record.dateEnd }}</calendarDate>
+                    </endDate>
+                </rangeOfDates>
+            </temporalCoverage>
         </coverage>
 
+    <maintenance>
+      <description>
+        <para/>
+      </description>
+      <maintenanceUpdateFrequency>asNeeded</maintenanceUpdateFrequency>
+    </maintenance>
+
+
     {% for contact in record.contacts %}
     {% if arrayOverlap(['pointOfContact', 'owner', 'author'],contact.role) %}
     <contact>
@@ -101,7 +119,7 @@
         <!-- <role> is used by associatedParty, buts its a single item not a list -->
         <!-- <role></role> -->
 
-        <userId directory="http://orcid.org">{{contact.indOrcid}}</userId>
+        <userId directory="https://orcid.org">{{contact.indOrcid}}</userId>
     </contact>
     {% endif %}
     {% endfor %}